Bug 139501

Summary: Please disable the webkitFirstVersionWithInitConstructorSupport check on Apple TV
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch barraclough: review+

Geoffrey Garen
Reported 2014-12-10 11:59:29 PST
Please disable the webkitFirstVersionWithInitConstructorSupport check on ATV
Attachments
Patch (2.67 KB, patch)
2014-12-10 12:56 PST, Geoffrey Garen 		barraclough: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2014-12-10 12:56:08 PST
Created attachment 243059 [details] Patch
Geoffrey Garen
Comment 2 2014-12-10 13:10:08 PST
Committed r177091: <http://trac.webkit.org/changeset/177091>
Joseph Pecoraro
Comment 3 2015-04-27 16:55:02 PDT
Comment on attachment 243059 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243059&action=review > Source/JavaScriptCore/API/JSWrapperMap.mm:664 > +#if PLATFORM(APPLETV) > + // There are no old clients on Apple TV, so there's no need for backwards compatibility. > + return true; > +#endif > + > static int32_t versionOfLinkTimeLibrary = 0; > if (!versionOfLinkTimeLibrary) > versionOfLinkTimeLibrary = NSVersionOfLinkTimeLibrary("JavaScriptCore"); I imagine that if we enabled unreachable code warnings it might complain about the unreachable code after the #if. Perhaps an #if/#else/#endif might be better.
Note You need to log in before you can comment on or make changes to this bug.