Bug 139501

Summary:

Please disable the webkitFirstVersionWithInitConstructorSupport check on Apple TV

Product:

WebKit

Reporter:

Geoffrey Garen <ggaren>

Component:

New Bugs

Assignee:

Geoffrey Garen <ggaren>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cmarcelo, commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	barraclough: review+

Description Geoffrey Garen 2014-12-10 11:59:29 PST

Please disable the webkitFirstVersionWithInitConstructorSupport check on ATV

Comment 1 Geoffrey Garen 2014-12-10 12:56:08 PST

Created attachment 243059 [details]
Patch

Comment 2 Geoffrey Garen 2014-12-10 13:10:08 PST

Committed r177091: <http://trac.webkit.org/changeset/177091>

Comment 3 Joseph Pecoraro 2015-04-27 16:55:02 PDT

Comment on attachment 243059 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243059&action=review

> Source/JavaScriptCore/API/JSWrapperMap.mm:664
> +#if PLATFORM(APPLETV)
> +    // There are no old clients on Apple TV, so there's no need for backwards compatibility.
> +    return true;
> +#endif
> +
>      static int32_t versionOfLinkTimeLibrary = 0;
>      if (!versionOfLinkTimeLibrary)
>          versionOfLinkTimeLibrary = NSVersionOfLinkTimeLibrary("JavaScriptCore");

I imagine that if we enabled unreachable code warnings it might complain about the unreachable code after the #if. Perhaps an #if/#else/#endif might be better.