Bug 139487

Summary: [GStreamer] Use a buffer pool for the allocations in AudioDestination
Product: WebKit Reporter: Sebastian Dröge (slomo) <slomo>
Component: MediaAssignee: Sebastian Dröge (slomo) <slomo>
Status: RESOLVED FIXED    
Severity: Minor CC: buildbot, commit-queue, pnormand, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 139490    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews107 for mac-mountainlion-wk2
none
Patch
none
Archive of layout-test-results from ews106 for mac-mountainlion-wk2 none

Description Sebastian Dröge (slomo) 2014-12-10 08:40:10 PST
Patch coming in a few seconds.
Comment 1 Sebastian Dröge (slomo) 2014-12-10 08:41:09 PST
Created attachment 243026 [details]
Patch
Comment 2 Build Bot 2014-12-10 09:18:25 PST
Comment on attachment 243026 [details]
Patch

Attachment 243026 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4519363323363328

New failing tests:
fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgb565.html
Comment 3 Build Bot 2014-12-10 09:18:28 PST
Created attachment 243031 [details]
Archive of layout-test-results from ews107 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 4 Philippe Normand 2014-12-10 09:42:26 PST
Comment on attachment 243026 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243026&action=review

> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:339
> +        GstFlowReturn flow_ret = gst_buffer_pool_acquire_buffer(priv->pool, &channelBuffer, nullptr);
> +
> +        if (flow_ret != GST_FLOW_OK) {

Here you could avoid the flow_ret local variable. BTW we prefer camelCase naming :p

> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:349
> +            gst_task_pause(src->priv->task.get());
> +            return;

Would be nice to emit an error message here but that's for another patch :)

> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:446
> +        config = gst_buffer_pool_get_config(src->priv->pool);

We try as much as possible to declare and assign variables in the same line. Here it could be done easily.
Comment 5 Sebastian Dröge (slomo) 2014-12-10 09:49:29 PST
Created attachment 243036 [details]
Patch
Comment 6 Philippe Normand 2014-12-10 10:04:36 PST
Comment on attachment 243036 [details]
Patch

LGTM!
Comment 7 Build Bot 2014-12-10 10:10:23 PST
Comment on attachment 243036 [details]
Patch

Attachment 243036 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5787313904812032

New failing tests:
fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgba4444.html
Comment 8 Build Bot 2014-12-10 10:10:27 PST
Created attachment 243041 [details]
Archive of layout-test-results from ews106 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 9 Philippe Normand 2014-12-10 10:37:50 PST
Comment on attachment 243036 [details]
Patch

Clearing flags on attachment: 243036

Committed r177079: <http://trac.webkit.org/changeset/177079>
Comment 10 Philippe Normand 2014-12-10 10:37:56 PST
All reviewed patches have been landed.  Closing bug.