Bug 139470

Summary:

Streamline and refactor font-related classes

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

New Bugs

Assignee:

Darin Adler <darin>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

buildbot, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
first cut	none
second try	none
another try	buildbot: commit-queue-
Archive of layout-test-results from ews101 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2	none

Darin Adler

Reported 2014-12-09 20:10:57 PST

Streamline and refactor font-related classes

Attachments
first cut (221.90 KB, patch) 2014-12-10 09:02 PST, Darin Adler	no flags	Details Formatted Diff Diff
second try (228.89 KB, patch) 2014-12-10 10:07 PST, Darin Adler	no flags	Details Formatted Diff Diff
another try (235.68 KB, patch) 2014-12-10 10:25 PST, Darin Adler	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-mountainlion (925.49 KB, application/zip) 2014-12-10 11:08 PST, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (859.47 KB, application/zip) 2014-12-10 11:57 PST, Build Bot	no flags	Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2014-12-10 09:02:04 PST

Created attachment 243028 [details] first cut

Darin Adler

Comment 2 2014-12-10 10:07:41 PST

Created attachment 243040 [details] second try

Darin Adler

Comment 3 2014-12-10 10:08:01 PST

Patch got too big; I’ll have to break it down into pieces again. Ugh.

Darin Adler

Comment 4 2014-12-10 10:25:56 PST

Created attachment 243046 [details] another try

Build Bot

Comment 5 2014-12-10 11:08:05 PST

Comment on attachment 243046 [details] another try Attachment 243046 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6477442671706112 New failing tests: fast/forms/text-control-intrinsic-widths.html svg/custom/altglyph.svg svg/text/multichar-glyph.svg

Build Bot

Comment 6 2014-12-10 11:08:08 PST

Created attachment 243050 [details] Archive of layout-test-results from ews101 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 7 2014-12-10 11:57:35 PST

Comment on attachment 243046 [details] another try Attachment 243046 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5052636663382016 New failing tests: fast/forms/text-control-intrinsic-widths.html svg/custom/altglyph.svg svg/text/multichar-glyph.svg

Build Bot

Comment 8 2014-12-10 11:57:37 PST

Created attachment 243055 [details] Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Darin Adler

Comment 9 2015-03-28 17:09:58 PDT

Antti made lots of changes to font code; not sure any of this applies any more.

Note You need to log in before you can comment on or make changes to this bug.