Bug 13947

Summary: Finish autogenerating the JS DOM traversal code
Product: WebKit Reporter: Sam Weinig <sam>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: Mac   
OS: OS X 10.4   
Bug Depends on:    
Bug Blocks: 13779    
Attachments:
Description Flags
patch hyatt: review+

Sam Weinig
Reported 2007-05-30 23:24:08 PDT
Patch on its way.
Attachments
patch (45.95 KB, patch)
2007-05-30 23:34 PDT, Sam Weinig 		hyatt: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2007-05-30 23:34:07 PDT
Created attachment 14798 [details] patch I am a little uneasy about this patch and wouldn't mind some harsh reviewing of it. The part I am uneasy about is the changing of the NodeFilter parameter of Document::createNodeIterator and Document::createTreeWalker to be regular pointers instead of PassRefPtrs. I did this becuase it makes generating a lot easier and that is how parameters are generally passed for the bindings. If there is any slowdown or other issues that this might cause I am sure I can come up with a work around in the bindings scripts, but I thought I would check if this way was OK first.
Dave Hyatt
Comment 2 2007-06-06 16:55:46 PDT
Comment on attachment 14798 [details] patch r=me
Sam Weinig
Comment 3 2007-06-06 18:55:17 PDT
Landed in r22035.
Note You need to log in before you can comment on or make changes to this bug.