Bug 139469

Summary: Simple line layout: Add 16bit support.
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, koivisto, kondapallykalyan, mmaxfield
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description zalan 2014-12-09 19:16:55 PST 
16bit support was temporarily removed at bug 138796.
Comment 1 zalan 2014-12-10 16:12:27 PST 
Created attachment 243077 [details]
Patch
Comment 2 zalan 2014-12-10 20:40:02 PST 
rdar://problem/19210121
Comment 3 Antti Koivisto 2014-12-11 08:37:08 PST 
Comment on attachment 243077 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243077&action=review

r=me

> Source/WebCore/rendering/SimpleLineLayoutFlowContents.h:84
> +    template <typename CharacterType>
>      float runWidth(const String&, unsigned from, unsigned to, float xPosition) const;

could put this on the same line
Comment 4 Myles C. Maxfield 2014-12-11 12:04:03 PST 
Comment on attachment 243077 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243077&action=review

> Source/WebCore/rendering/SimpleLineLayoutFlowContents.cpp:137
> +            runWidth<UChar>(segment->text, from - segment->start, fragmentEnd - segment->start, xPosition + textWidth);

Yuck.
Comment 5 zalan 2014-12-11 12:40:48 PST 
Created attachment 243139 [details]
Patch
Comment 6 WebKit Commit Bot 2014-12-12 03:49:17 PST 
Comment on attachment 243139 [details]
Patch

Clearing flags on attachment: 243139

Committed r177219: <http://trac.webkit.org/changeset/177219>
Comment 7 WebKit Commit Bot 2014-12-12 03:49:22 PST 
All reviewed patches have been landed.  Closing bug.