Bug 139469

Summary: Simple line layout: Add 16bit support.
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, koivisto, kondapallykalyan, mmaxfield
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

alan
Reported 2014-12-09 19:16:55 PST
16bit support was temporarily removed at bug 138796.
Attachments
Patch (11.35 KB, patch)
2014-12-10 16:12 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (11.48 KB, patch)
2014-12-11 12:40 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2014-12-10 16:12:27 PST
Created attachment 243077 [details] Patch
alan
Comment 2 2014-12-10 20:40:02 PST
rdar://problem/19210121
Antti Koivisto
Comment 3 2014-12-11 08:37:08 PST
Comment on attachment 243077 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243077&action=review r=me > Source/WebCore/rendering/SimpleLineLayoutFlowContents.h:84 > + template <typename CharacterType> > float runWidth(const String&, unsigned from, unsigned to, float xPosition) const; could put this on the same line
Myles C. Maxfield
Comment 4 2014-12-11 12:04:03 PST
Comment on attachment 243077 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243077&action=review > Source/WebCore/rendering/SimpleLineLayoutFlowContents.cpp:137 > + runWidth<UChar>(segment->text, from - segment->start, fragmentEnd - segment->start, xPosition + textWidth); Yuck.
alan
Comment 5 2014-12-11 12:40:48 PST
Created attachment 243139 [details] Patch
WebKit Commit Bot
Comment 6 2014-12-12 03:49:17 PST
Comment on attachment 243139 [details] Patch Clearing flags on attachment: 243139 Committed r177219: <http://trac.webkit.org/changeset/177219>
WebKit Commit Bot
Comment 7 2014-12-12 03:49:22 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.