Bug 139460

Summary: Provide SPI to asynchronously move a WKView into a window and know when it has painted
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, cgarcia, clopez, commit-queue, conrad_shultz, mitz, ossy, sam, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 139513    
Bug Blocks:    
Attachments:
Description Flags
Patch andersca: review+

Tim Horton
Reported 2014-12-09 14:45:43 PST
Provide SPI to asynchronously move a WKView into a window and know when it has painted
Attachments
Patch (26.17 KB, patch)
2014-12-09 14:46 PST, Tim Horton
andersca: review+
Tim Horton
Comment 1 2014-12-09 14:46:12 PST
Tim Horton
Comment 2 2014-12-09 14:46:35 PST
WebKit Commit Bot
Comment 3 2014-12-09 14:48:32 PST
Attachment 242967 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:2830: The parameter name "window" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 4 2014-12-10 12:07:59 PST
Comment on attachment 242967 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=242967&action=review > Source/WebKit2/UIProcess/API/mac/WKView.mm:2530 > + // If we're in the middle of preparing to move to a window, ignore actual moves. > + if (_data->_targetWindowForMovePreparation && window != _data->_targetWindowForMovePreparation) > + return; Is this even allowed? :| > Source/WebKit2/UIProcess/WebPageProxy.cpp:1172 > +{ space after void. > Source/WebKit2/UIProcess/WebPageProxy.cpp:1178 > + void(^copiedCompletionHandler)() = Block_copy(completionHandler); auto.
Tim Horton
Comment 5 2014-12-10 15:00:00 PST
Tim Horton
Comment 6 2014-12-10 15:16:13 PST
Csaba Osztrogonác
Comment 8 2014-12-11 04:11:14 PST
Note You need to log in before you can comment on or make changes to this bug.