Bug 139455

Summary:

Implement clearing of cookies

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, kling, ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	kling: review+

Description Anders Carlsson 2014-12-09 11:29:35 PST

Implement clearing of cookies

Comment 1 Anders Carlsson 2014-12-09 11:36:45 PST

Created attachment 242950 [details]
Patch

Comment 2 WebKit Commit Bot 2014-12-09 11:39:56 PST

Attachment 242950 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h:65:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h:102:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp:112:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp:115:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp:140:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp:118:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.h:56:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 7 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Andreas Kling 2014-12-09 12:15:22 PST

Comment on attachment 242950 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242950&action=review

r=me

> Source/WebKit2/NetworkProcess/NetworkProcess.cpp:246
> +    parentProcessConnection()->send(Messages::NetworkProcessProxy::DidDeleteWebsiteData(callbackID), 0);

Can we make parentProcessConnection() return a reference?

> Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp:94
> +enum class ProcessAccessType {
> +    None,
> +    OnlyIfLaunched,
> +    Launch,
> +};

This is very nifty.

Comment 4 Anders Carlsson 2014-12-09 12:29:33 PST

Committed r177032: <http://trac.webkit.org/changeset/177032>

Comment 5 Csaba Osztrogonác 2014-12-09 16:13:24 PST

and the buildfix landed in https://trac.webkit.org/changeset/177043