Bug 139434

Summary:

[CMAKE] bump GSTREAMER required version to 1.2.0

Product:

WebKit

Reporter:

Fabien Vallée <fvallee>

Component:

Media

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED INVALID

Severity:

Minor

CC:

cgarcia, jberta.u-szeged, pnormand

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	mrobinson: review-

Description Fabien Vallée 2014-12-09 01:44:10 PST

Cmake is defined required version for gstreamer as "1.0.3" but it cannot compile anymore.

Following commit: "[GStreamer] HTTP source element lacks SCHEDULING query support" http://trac.webkit.org/changeset/17656
is introducing "GST_SCHEDULING_FLAG_BANDWIDTH_LIMITED" flags which is defined only in gstreamer >= 1.2.0
(https://developer.gnome.org/gstreamer/stable/gstreamer-GstQuery.html#GstSchedulingFlags)

Jhbuild is using 
gtk: gstreamer 1.4.4 (https://bugs.webkit.org/show_bug.cgi?id=138866)
efl: gstreamer1.2.1  (https://bugs.webkit.org/show_bug.cgi?id=125155)

so it should be safe to set 1.2.0 required in cmake.

Comment 1 Fabien Vallée 2014-12-09 01:55:06 PST

Created attachment 242897 [details]
Patch

Comment 2 Fabien Vallée 2014-12-09 02:06:17 PST

there is a typo in my previous comment, 
correct link to gstreamer patch introducing GST_SCHEDULING_FLAG_BANDWIDTH_LIMITED is :

"[GStreamer] HTTP source element lacks SCHEDULING query support" http://trac.webkit.org/changeset/176561

Comment 3 Martin Robinson 2014-12-09 02:10:17 PST

Comment on attachment 242897 [details]
Patch

We cannot bump the required version of GStreamer for WebKitGTK+, but we can use conditional compilation to enable features when compiling against a newer version.

Comment 4 Philippe Normand 2014-12-09 02:12:35 PST

Right, it was my mistake, the SCHEDULING query code should be guarded with a ifdef.

Comment 5 Fabien Vallée 2014-12-09 02:15:57 PST

ok, use compile guards is indeed a very good solution ;)