Bug 139431

Summary:

Unskip more multipart tests

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Tools / Tests

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, koivisto, mitz, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch	buildbot: commit-queue-
Archive of layout-test-results from ews102 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2	none
proposed patch	none

Alexey Proskuryakov

Reported 2014-12-08 23:49:16 PST

http/tests/multipart/invalid-image-data-standalone.html uses resources/multipart.php, which was fixed today. It seems like a fairly weak test, and it mostly duplicates http/tests/multipart/multipart-image.html, but given how poor multipart test coverage is, it may be worth enabling if we can. http/tests/multipart/load-last-non-html-frame.php has the same bug as resources/multipart.php had, which can be simply fixed.

Attachments
proposed patch (2.36 KB, patch) 2014-12-08 23:52 PST, Alexey Proskuryakov	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-mountainlion (504.44 KB, application/zip) 2014-12-09 00:39 PST, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 (512.36 KB, application/zip) 2014-12-09 01:03 PST, Build Bot	no flags	Details
proposed patch (2.45 KB, patch) 2014-12-09 19:15 PST, Alexey Proskuryakov	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2014-12-08 23:52:58 PST

Created attachment 242887 [details] proposed patch I only tested on Yosemite, let's see what EWS thinks.

Build Bot

Comment 2 2014-12-09 00:39:14 PST

Comment on attachment 242887 [details] proposed patch Attachment 242887 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4980705087979520 New failing tests: http/tests/multipart/invalid-image-data-standalone.html

Build Bot

Comment 3 2014-12-09 00:39:17 PST

Created attachment 242890 [details] Archive of layout-test-results from ews102 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 4 2014-12-09 01:03:27 PST

Comment on attachment 242887 [details] proposed patch Attachment 242887 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5239392578830336 New failing tests: http/tests/multipart/invalid-image-data-standalone.html

Build Bot

Comment 5 2014-12-09 01:03:30 PST

Created attachment 242895 [details] Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Alexey Proskuryakov

Comment 6 2014-12-09 19:15:13 PST

Created attachment 242984 [details] proposed patch OK, let's unskip it on Mavericks only, where it passed for me. It may be the same issue I observed with http/tests/multipart/multipart-image.html, where we were two frames behind instead of one frame behind.

Darin Adler

Comment 7 2014-12-09 20:07:40 PST

Comment on attachment 242984 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=242984&action=review > LayoutTests/ChangeLog:8 > + * http/tests/multipart/load-last-non-html-frame.php: No explanation of the change?

WebKit Commit Bot

Comment 8 2014-12-09 22:43:32 PST

Comment on attachment 242984 [details] proposed patch Clearing flags on attachment: 242984 Committed r177054: <http://trac.webkit.org/changeset/177054>

WebKit Commit Bot

Comment 9 2014-12-09 22:43:36 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.