Summary: | Unskip more multipart tests | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||||||||
Component: | Tools / Tests | Assignee: | Alexey Proskuryakov <ap> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, koivisto, mitz, rniwa | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Alexey Proskuryakov
2014-12-08 23:49:16 PST
Created attachment 242887 [details]
proposed patch
I only tested on Yosemite, let's see what EWS thinks.
Comment on attachment 242887 [details] proposed patch Attachment 242887 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4980705087979520 New failing tests: http/tests/multipart/invalid-image-data-standalone.html Created attachment 242890 [details]
Archive of layout-test-results from ews102 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 242887 [details] proposed patch Attachment 242887 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5239392578830336 New failing tests: http/tests/multipart/invalid-image-data-standalone.html Created attachment 242895 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Created attachment 242984 [details]
proposed patch
OK, let's unskip it on Mavericks only, where it passed for me. It may be the same issue I observed with http/tests/multipart/multipart-image.html, where we were two frames behind instead of one frame behind.
Comment on attachment 242984 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=242984&action=review > LayoutTests/ChangeLog:8 > + * http/tests/multipart/load-last-non-html-frame.php: No explanation of the change? Comment on attachment 242984 [details] proposed patch Clearing flags on attachment: 242984 Committed r177054: <http://trac.webkit.org/changeset/177054> All reviewed patches have been landed. Closing bug. |