Bug 139420

Summary: Move 'text-shadow' check from RenderStyle::changeRequiresLayout() to changeAffectsVisualOverflow()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Layout and RenderingAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, hyatt, kondapallykalyan, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2014-12-08 15:52:12 PST
Move 'text-shadow' check from RenderStyle::changeRequiresLayout() to changeAffectsVisualOverflow(). This has no behavior change as changeRequiresLayout() calls changeAffectsVisualOverflow(). However, this is clearer as text-shadow affects the visual overflow (similarly to box-shadow).
Attachments
Patch (2.53 KB, patch)
2014-12-08 16:03 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2014-12-08 16:03:21 PST
Created attachment 242859 [details] Patch
WebKit Commit Bot
Comment 2 2014-12-08 17:27:54 PST
Comment on attachment 242859 [details] Patch Clearing flags on attachment: 242859 Committed r176998: <http://trac.webkit.org/changeset/176998>
WebKit Commit Bot
Comment 3 2014-12-08 17:28:01 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.