Bug 139420

Summary:

Move 'text-shadow' check from RenderStyle::changeRequiresLayout() to changeAffectsVisualOverflow()

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Layout and Rendering

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, glenn, hyatt, kondapallykalyan, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Chris Dumez 2014-12-08 15:52:12 PST

Move 'text-shadow' check from RenderStyle::changeRequiresLayout() to changeAffectsVisualOverflow(). This has no behavior change as changeRequiresLayout() calls changeAffectsVisualOverflow(). However, this is clearer as text-shadow affects the visual overflow (similarly to box-shadow).

Comment 1 Chris Dumez 2014-12-08 16:03:21 PST

Created attachment 242859 [details]
Patch

Comment 2 WebKit Commit Bot 2014-12-08 17:27:54 PST

Comment on attachment 242859 [details]
Patch

Clearing flags on attachment: 242859

Committed r176998: <http://trac.webkit.org/changeset/176998>

Comment 3 WebKit Commit Bot 2014-12-08 17:28:01 PST

All reviewed patches have been landed.  Closing bug.