Summary: | Fix the parsing of advanced :lang() after r176902 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Benjamin Poulain <benjamin> | ||||
Component: | New Bugs | Assignee: | Benjamin Poulain <benjamin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, diorahman, kling, mark.lam | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Benjamin Poulain
2014-12-07 17:51:44 PST
Created attachment 242782 [details]
Patch
Comment on attachment 242782 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=242782&action=review > Source/WebCore/css/CSSParser.cpp:11489 > + } If you want this ‘}’, then you should move the one at line 11503 before the #endif. Comment on attachment 242782 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=242782&action=review >> Source/WebCore/css/CSSParser.cpp:11489 >> + } > > If you want this ‘}’, then you should move the one at line 11503 before the #endif. Oh crap, my bad. I'll fix that before landing. Comment on attachment 242782 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=242782&action=review r=me > Source/WebCore/ChangeLog:18 > + The problem is that CSSParserString does not keep the source string alive. > + Consequently, the list of language range was accumulating pointers to dead > + StringImpls. Whoops! Committed r176983: <http://trac.webkit.org/changeset/176983> |