Bug 139360

Summary: [GStreamer] Use audio-filter property for pitch-preserving element
Product: WebKit Reporter: Sebastian Dröge (slomo) <slomo>
Component: MediaAssignee: Sebastian Dröge (slomo) <slomo>
Status: RESOLVED FIXED    
Severity: Trivial CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Sebastian Dröge (slomo)
Reported 2014-12-07 04:28:42 PST
Patch coming in a second. Together with my next change this allows us to use playbin's special sink selection mechanisms, which will allow us to automatically use sinks that handle compressed input if possible. But even alone it makes the code a bit simpler (once we can depend on >= 1.4.2).
Attachments
Patch (2.95 KB, patch)
2014-12-07 04:30 PST, Sebastian Dröge (slomo) 		no flags
DetailsFormatted DiffDiff
Patch (2.95 KB, patch)
2014-12-07 10:41 PST, Sebastian Dröge (slomo) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sebastian Dröge (slomo)
Comment 1 2014-12-07 04:30:48 PST
Created attachment 242739 [details] Patch
Gustavo Noronha (kov)
Comment 2 2014-12-07 10:08:44 PST
Comment on attachment 242739 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=242739&action=review > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1834 > + // On 1.4.2 and newer we use the audio-filter property instead Nit: missing full stop.
Sebastian Dröge (slomo)
Comment 3 2014-12-07 10:41:42 PST
Created attachment 242757 [details] Patch
WebKit Commit Bot
Comment 4 2014-12-08 01:22:56 PST
Comment on attachment 242757 [details] Patch Clearing flags on attachment: 242757 Committed r176939: <http://trac.webkit.org/changeset/176939>
WebKit Commit Bot
Comment 5 2014-12-08 01:22:59 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.