Bug 139360

Summary:

[GStreamer] Use audio-filter property for pitch-preserving element

Product:

WebKit

Reporter:

Sebastian Dröge (slomo) <slomo>

Component:

Media

Assignee:

Sebastian Dröge (slomo) <slomo>

Status:

RESOLVED FIXED

Severity:

Trivial

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Sebastian Dröge (slomo) 2014-12-07 04:28:42 PST

Patch coming in a second. Together with my next change this allows us to use playbin's special sink selection mechanisms, which will allow us to automatically use sinks that handle compressed input if possible. But even alone it makes the code a bit simpler (once we can depend on >= 1.4.2).

Comment 1 Sebastian Dröge (slomo) 2014-12-07 04:30:48 PST

Created attachment 242739 [details]
Patch

Comment 2 Gustavo Noronha (kov) 2014-12-07 10:08:44 PST

Comment on attachment 242739 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242739&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1834
> +    // On 1.4.2 and newer we use the audio-filter property instead

Nit: missing full stop.

Comment 3 Sebastian Dröge (slomo) 2014-12-07 10:41:42 PST

Created attachment 242757 [details]
Patch

Comment 4 WebKit Commit Bot 2014-12-08 01:22:56 PST

Comment on attachment 242757 [details]
Patch

Clearing flags on attachment: 242757

Committed r176939: <http://trac.webkit.org/changeset/176939>

Comment 5 WebKit Commit Bot 2014-12-08 01:22:59 PST

All reviewed patches have been landed.  Closing bug.