| Summary: | [GDK] Enable logging | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alp Toker <alp> | ||||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | ||||||||||
| Priority: | P2 | ||||||||||
| Version: | 523.x (Safari 3) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Alp Toker
2007-05-30 12:13:59 PDT
Created attachment 14788 [details]
Enable logging
Comment on attachment 14788 [details]
Enable logging
r- for now. This seems good but could you please include the URL of the bugzilla bug and the title in the changeLog. Also, please add a FIXME to InitializeLoggingChannelsIfNecessary() stating an intent to add a way for users to pass what channels they want to turn on in the future.
Since the recent changes, the information has been a bit less useful: dispatchDidFinishLoading is not implemented Previously, the prototype and line number were included: FIXME: UNIMPLEMENTED virtual void WebCore::FrameLoaderClientGdk::dispatchDidFinishLoading(WebCore::DocumentLoader*, long unsigned int) ../../../WebCore/loader/gdk/FrameLoaderClientGdk.cpp:305 Created attachment 14792 [details]
Enable logging, take two
Created attachment 14793 [details]
Slight update
Alp, I have taken your patch and made some slight changes including adding a comment in LoggingGdk.cpp and changing the NotImplemented log to use the WTFLogVerbose which should print out file, line number and function. Thoughts?
Comment on attachment 14793 [details]
Slight update
Reviewed by Brady.
|