Created attachment 14788 [details]
Comment on attachment 14788 [details]
r- for now. This seems good but could you please include the URL of the bugzilla bug and the title in the changeLog. Also, please add a FIXME to InitializeLoggingChannelsIfNecessary() stating an intent to add a way for users to pass what channels they want to turn on in the future.
Since the recent changes, the information has been a bit less useful:
dispatchDidFinishLoading is not implemented
Previously, the prototype and line number were included:
FIXME: UNIMPLEMENTED virtual void WebCore::FrameLoaderClientGdk::dispatchDidFinishLoading(WebCore::DocumentLoader*, long unsigned int) ../../../WebCore/loader/gdk/FrameLoaderClientGdk.cpp:305
Created attachment 14792 [details]
Enable logging, take two
Created attachment 14793 [details]
Alp, I have taken your patch and made some slight changes including adding a comment in LoggingGdk.cpp and changing the NotImplemented log to use the WTFLogVerbose which should print out file, line number and function. Thoughts?
Comment on attachment 14793 [details]
Reviewed by Brady.
Landed in r21906.