Bug 13936 - [GDK] Enable logging
Summary: [GDK] Enable logging
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 523.x (Safari 3)
Hardware: All All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2007-05-30 12:13 PDT by Alp Toker
Modified: 2007-05-30 17:30 PDT (History)
0 users

See Also:

Enable logging (3.87 KB, patch)
2007-05-30 12:17 PDT, Alp Toker
sam: review-
Details | Formatted Diff | Diff
Enable logging, take two (3.98 KB, patch)
2007-05-30 15:38 PDT, Alp Toker
no flags Details | Formatted Diff | Diff
Slight update (10.02 KB, patch)
2007-05-30 16:56 PDT, Sam Weinig
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alp Toker 2007-05-30 12:13:59 PDT
Patch attached.
Comment 1 Alp Toker 2007-05-30 12:17:00 PDT
Created attachment 14788 [details]
Enable logging
Comment 2 Sam Weinig 2007-05-30 12:28:49 PDT
Comment on attachment 14788 [details]
Enable logging

r- for now.  This seems good but could you please include the URL of the bugzilla bug and the title in the changeLog. Also, please add a FIXME to InitializeLoggingChannelsIfNecessary() stating an intent to add a way for users to pass what channels they want to turn on in the future.
Comment 3 Alp Toker 2007-05-30 12:29:45 PDT
Since the recent changes, the information has been a bit less useful:

dispatchDidFinishLoading is not implemented

Previously, the prototype and line number were included:

FIXME: UNIMPLEMENTED virtual void WebCore::FrameLoaderClientGdk::dispatchDidFinishLoading(WebCore::DocumentLoader*, long unsigned int) ../../../WebCore/loader/gdk/FrameLoaderClientGdk.cpp:305
Comment 4 Alp Toker 2007-05-30 15:38:48 PDT
Created attachment 14792 [details]
Enable logging, take two
Comment 5 Sam Weinig 2007-05-30 16:56:05 PDT
Created attachment 14793 [details]
Slight update

Alp, I have taken your patch and made some slight changes including adding a comment in LoggingGdk.cpp and changing the NotImplemented log to use the WTFLogVerbose which should print out file, line number and function.  Thoughts?
Comment 6 Sam Weinig 2007-05-30 17:30:27 PDT
Comment on attachment 14793 [details]
Slight update

Reviewed by Brady.
Comment 7 Sam Weinig 2007-05-30 17:30:46 PDT
Landed in r21906.