| Summary: | [GStreamer] Handle CLOCK_LOST and LATENCY messages | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sebastian Dröge (slomo) <slomo> | ||||
| Component: | Media | Assignee: | Sebastian Dröge (slomo) <slomo> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, pnormand | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Sebastian Dröge (slomo)
2014-12-06 08:55:18 PST
Patch coming once my testbuild has finished in a few minutes :) Created attachment 242717 [details]
Patch
I think Brendan had already CLOCK_LOST support in of his recent patches? The one he doesn't want to land :) Possible, I didn't look at that patch yet but it's a good thing to merge independent of all the other stuff he has in his patch and simple enough :) Comment on attachment 242717 [details]
Patch
Why doesn't he want to land it? Are these messages things we can test?
You could probably test it but setting up an environment to run into actual problems with these will be a lot of work. It's the right thing to do though, it's what we recommend in the documentation and also in gst-launch for example. He doesn't want to land his patches because the actual thing they're implementing (disabling audio/video streams) does not work reliable because of bugs somewhere. Comment on attachment 242717 [details]
Patch
Ok!
Comment on attachment 242717 [details] Patch Clearing flags on attachment: 242717 Committed r176940: <http://trac.webkit.org/changeset/176940> All reviewed patches have been landed. Closing bug. |