Bug 139341

Summary: [GStreamer] Handle CLOCK_LOST and LATENCY messages
Product: WebKit Reporter: Sebastian Dröge (slomo) <slomo>
Component: MediaAssignee: Sebastian Dröge (slomo) <slomo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, pnormand
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Sebastian Dröge (slomo)
Reported 2014-12-06 08:55:18 PST
[GStreamer] Handle CLOCK_LOST and LATENCY messages
Attachments
Patch (3.35 KB, patch)
2014-12-06 10:11 PST, Sebastian Dröge (slomo) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sebastian Dröge (slomo)
Comment 1 2014-12-06 09:11:43 PST
Patch coming once my testbuild has finished in a few minutes :)
Sebastian Dröge (slomo)
Comment 2 2014-12-06 10:11:15 PST
Created attachment 242717 [details] Patch
Philippe Normand
Comment 3 2014-12-07 06:53:03 PST
I think Brendan had already CLOCK_LOST support in of his recent patches? The one he doesn't want to land :)
Sebastian Dröge (slomo)
Comment 4 2014-12-07 07:31:17 PST
Possible, I didn't look at that patch yet but it's a good thing to merge independent of all the other stuff he has in his patch and simple enough :)
Gustavo Noronha (kov)
Comment 5 2014-12-07 10:11:04 PST
Comment on attachment 242717 [details] Patch Why doesn't he want to land it? Are these messages things we can test?
Sebastian Dröge (slomo)
Comment 6 2014-12-07 10:32:57 PST
You could probably test it but setting up an environment to run into actual problems with these will be a lot of work. It's the right thing to do though, it's what we recommend in the documentation and also in gst-launch for example. He doesn't want to land his patches because the actual thing they're implementing (disabling audio/video streams) does not work reliable because of bugs somewhere.
Philippe Normand
Comment 7 2014-12-07 12:57:18 PST
Comment on attachment 242717 [details] Patch Ok!
WebKit Commit Bot
Comment 8 2014-12-08 01:24:28 PST
Comment on attachment 242717 [details] Patch Clearing flags on attachment: 242717 Committed r176940: <http://trac.webkit.org/changeset/176940>
WebKit Commit Bot
Comment 9 2014-12-08 01:24:32 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.