Bug 139323

Summary: Get rid of config.h includes and include config.h in the prefix header instead
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, glenn, jer.noble, philipj, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch bfulgham: review+

Anders Carlsson
Reported 2014-12-05 16:23:27 PST
Get rid of config.h includes and include config.h in the prefix header instead
Attachments
Patch (42.81 KB, patch)
2014-12-05 16:24 PST, Anders Carlsson 		bfulgham: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2014-12-05 16:24:02 PST
Created attachment 242676 [details] Patch
Brent Fulgham
Comment 2 2014-12-05 16:25:47 PST
Comment on attachment 242676 [details] Patch This looks good to me. Do we run into any style bot problems since the files no longer begin with "config.h" as the first include file?
WebKit Commit Bot
Comment 3 2014-12-05 16:26:31 PST
Attachment 242676 [details] did not pass style-queue: ERROR: Source/WebKit/win/WebKitPrefix.h:51: Header file should not contain WebCore config.h. Should be: alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 4 2014-12-05 16:33:07 PST
Committed r176892: <http://trac.webkit.org/changeset/176892>
Note You need to log in before you can comment on or make changes to this bug.