Bug 139323 - Get rid of config.h includes and include config.h in the prefix header instead
Summary: Get rid of config.h includes and include config.h in the prefix header instead
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-05 16:23 PST by Anders Carlsson
Modified: 2014-12-05 16:33 PST (History)
6 users (show)

See Also:

Attachments
Patch (42.81 KB, patch)
2014-12-05 16:24 PST, Anders Carlsson 		bfulgham: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-12-05 16:23:27 PST 
Get rid of config.h includes and include config.h in the prefix header instead
Comment 1 Anders Carlsson 2014-12-05 16:24:02 PST 
Created attachment 242676 [details]
Patch
Comment 2 Brent Fulgham 2014-12-05 16:25:47 PST 
Comment on attachment 242676 [details]
Patch

This looks good to me. Do we run into any style bot problems since the files no longer begin with "config.h" as the first include file?
Comment 3 WebKit Commit Bot 2014-12-05 16:26:31 PST 
Attachment 242676 [details] did not pass style-queue:


ERROR: Source/WebKit/win/WebKitPrefix.h:51:  Header file should not contain WebCore config.h. Should be: alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Anders Carlsson 2014-12-05 16:33:07 PST 
Committed r176892: <http://trac.webkit.org/changeset/176892>