Summary: | [iOS] DumpRenderTree produces many reference test mismatches | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||
Component: | Tools / Tests | Assignee: | Daniel Bates <dbates> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ddkilzer, simon.fraser, thorton | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | iPhone / iPad | ||||||
OS: | iOS 8.1 | ||||||
Bug Depends on: | 137581 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Daniel Bates
2014-12-05 14:02:35 PST
Created attachment 242661 [details]
Patch
Comment on attachment 242661 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=242661&action=review > Tools/DumpRenderTree/ios/PixelDumpSupportIOS.mm:88 > + UIGraphicsBeginImageContextWithOptions([[mainFrame webView] frame].size, TRUE, WKGetScreenScaleFactor()); TRUE -> YES > Tools/DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:31 > +OTHER_LDFLAGS_iphoneos = $(inherited) -l$(WEBKIT_SYSTEM_INTERFACE_LIBRARY) -lWebCoreTestSupport -force_load $(BUILT_PRODUCTS_DIR)/libDumpRenderTree.a -framework QuartzCore -framework CFNetwork -framework CoreFoundation -framework CoreGraphics -framework Foundation -framework GraphicsServices -framework ImageIO -framework MobileCoreServices -lMobileGestalt -framework UIKit -framework WebCore -framework JavaScriptCore -framework WebKit $(OTHER_LDFLAGS_FONTS); Why this change? (In reply to comment #2) > > Tools/DumpRenderTree/ios/PixelDumpSupportIOS.mm:88 > > + UIGraphicsBeginImageContextWithOptions([[mainFrame webView] frame].size, TRUE, WKGetScreenScaleFactor()); > > TRUE -> YES > Will fix. > > Tools/DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:31 > > +OTHER_LDFLAGS_iphoneos = $(inherited) -l$(WEBKIT_SYSTEM_INTERFACE_LIBRARY) -lWebCoreTestSupport -force_load $(BUILT_PRODUCTS_DIR)/libDumpRenderTree.a -framework QuartzCore -framework CFNetwork -framework CoreFoundation -framework CoreGraphics -framework Foundation -framework GraphicsServices -framework ImageIO -framework MobileCoreServices -lMobileGestalt -framework UIKit -framework WebCore -framework JavaScriptCore -framework WebKit $(OTHER_LDFLAGS_FONTS); > > Why this change? Will revert this change. Will fix WebKitSystemInterface for iOS to avoid linking library MobileGestalt. Committed r176880: <http://trac.webkit.org/changeset/176880> |