Bug 139314 – [iOS] DumpRenderTree produces many reference test mismatches

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Daniel Bates]

Many reference tests fail due to a scale factor mismatch in the snapshot of the test and the snapshot of its expected result. You can see such mismatches by using run-webkit-tests to run the following set of tests in the iOS Simulator with --fully-parallel, --child-processes=3, --no-retry-failures, --no-sample-on-timeout (*): LayoutTests/css2.1/20110323/at-import-001.htm, LayoutTests/css2.1/20110323/at-import-002.htm, LayoutTests/css2.1/20110323/at-import-003.htm, and LayoutTests/css2.1/20110323/at-import-004.htm.

(*) Pass these tests as command line arguments of a single run-webkit-tests run. That is, run something of the form: Tools/Scripts/run-webkit-tests --ios-sim --fully-parallel --child-processes=3 --no-retry-failures --no-sample-on-timeout ... LayoutTests/css2.1/20110323/at-import-001.htm LayoutTests/css2.1/20110323/at-import-002.htm LayoutTests/css2.1/20110323/at-import-003.htm LayoutTests/css2.1/20110323/at-import-004.htm.

[Daniel Bates]

Created attachment 242661 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 242661 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242661&action=review

> Tools/DumpRenderTree/ios/PixelDumpSupportIOS.mm:88
> +    UIGraphicsBeginImageContextWithOptions([[mainFrame webView] frame].size, TRUE, WKGetScreenScaleFactor());

TRUE -> YES

> Tools/DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:31
> +OTHER_LDFLAGS_iphoneos = $(inherited) -l$(WEBKIT_SYSTEM_INTERFACE_LIBRARY) -lWebCoreTestSupport -force_load $(BUILT_PRODUCTS_DIR)/libDumpRenderTree.a -framework QuartzCore -framework CFNetwork -framework CoreFoundation -framework CoreGraphics -framework Foundation -framework GraphicsServices -framework ImageIO -framework MobileCoreServices -lMobileGestalt -framework UIKit -framework WebCore -framework JavaScriptCore -framework WebKit $(OTHER_LDFLAGS_FONTS);

Why this change?

[Daniel Bates]

(In reply to comment #2)
> > Tools/DumpRenderTree/ios/PixelDumpSupportIOS.mm:88
> > +    UIGraphicsBeginImageContextWithOptions([[mainFrame webView] frame].size, TRUE, WKGetScreenScaleFactor());
> 
> TRUE -> YES
> 

Will fix.

> > Tools/DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:31
> > +OTHER_LDFLAGS_iphoneos = $(inherited) -l$(WEBKIT_SYSTEM_INTERFACE_LIBRARY) -lWebCoreTestSupport -force_load $(BUILT_PRODUCTS_DIR)/libDumpRenderTree.a -framework QuartzCore -framework CFNetwork -framework CoreFoundation -framework CoreGraphics -framework Foundation -framework GraphicsServices -framework ImageIO -framework MobileCoreServices -lMobileGestalt -framework UIKit -framework WebCore -framework JavaScriptCore -framework WebKit $(OTHER_LDFLAGS_FONTS);
> 
> Why this change?

Will revert this change. Will fix WebKitSystemInterface for iOS to avoid linking library MobileGestalt.

[Daniel Bates]

Committed r176880: <http://trac.webkit.org/changeset/176880>

[Daniel Bates]

<rdar://problem/18642889>