Summary: | Web Inspector: Hide Compositing Borders Button if backend returns an error that it is unsupported | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | graouts, joepeck, timothy, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Joseph Pecoraro
2014-12-05 12:13:44 PST
Created attachment 242655 [details]
[PATCH] Proposed Fix
Comment on attachment 242655 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=242655&action=review > Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:450 > + if (error === "unsupported") > + button.enabled = false; Is this really a one-shot? I would have expected this to say: button.enabled = error !== "unsupported"; Comment on attachment 242655 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=242655&action=review >> Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:450 >> + button.enabled = false; > > Is this really a one-shot? I would have expected this to say: > > button.enabled = error !== "unsupported"; You're right, it isn't exactly a one-shot. It would happen each time the DOMTreeContentView is shown. I'll take your suggestion, this is not performance sensitive. |