Bug 139291

Summary:

WKBundleCSSStyleDeclarationRef needs to be a real API::Object

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

New Bugs

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, mitz

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	mitz: review+

Description Sam Weinig 2014-12-04 22:24:20 PST

WKBundleCSSStyleDeclarationRef needs to be a real API::Object

Comment 1 Sam Weinig 2014-12-04 22:29:17 PST

Created attachment 242618 [details]
Patch

Comment 2 Sam Weinig 2014-12-04 22:29:47 PST

Created attachment 242619 [details]
Patch

Comment 3 mitz 2014-12-04 22:56:44 PST

Comment on attachment 242619 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242619&action=review

> Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleCSSStyleDeclarationHandle.h:45
> +    static PassRefPtr<InjectedBundleCSSStyleDeclarationHandle> create(WebCore::CSSStyleDeclaration&);

This isn’t implemented anywhere?

Comment 4 Sam Weinig 2014-12-04 23:21:25 PST

(In reply to comment #3)
> Comment on attachment 242619 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=242619&action=review
> 
> > Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleCSSStyleDeclarationHandle.h:45
> > +    static PassRefPtr<InjectedBundleCSSStyleDeclarationHandle> create(WebCore::CSSStyleDeclaration&);
> 
> This isn’t implemented anywhere?

Oops. I will remove it.

Comment 5 Anders Carlsson 2014-12-05 10:29:43 PST

Committed r176849: <http://trac.webkit.org/changeset/176849>