Bug 139291

Summary: WKBundleCSSStyleDeclarationRef needs to be a real API::Object
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, mitz
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch mitz: review+

Sam Weinig
Reported 2014-12-04 22:24:20 PST
WKBundleCSSStyleDeclarationRef needs to be a real API::Object
Attachments
Patch (14.55 KB, patch)
2014-12-04 22:29 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (14.55 KB, patch)
2014-12-04 22:29 PST, Sam Weinig 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2014-12-04 22:29:17 PST
Created attachment 242618 [details] Patch
Sam Weinig
Comment 2 2014-12-04 22:29:47 PST
Created attachment 242619 [details] Patch
mitz
Comment 3 2014-12-04 22:56:44 PST
Comment on attachment 242619 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=242619&action=review > Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleCSSStyleDeclarationHandle.h:45 > + static PassRefPtr<InjectedBundleCSSStyleDeclarationHandle> create(WebCore::CSSStyleDeclaration&); This isn’t implemented anywhere?
Sam Weinig
Comment 4 2014-12-04 23:21:25 PST
(In reply to comment #3) > Comment on attachment 242619 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=242619&action=review > > > Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleCSSStyleDeclarationHandle.h:45 > > + static PassRefPtr<InjectedBundleCSSStyleDeclarationHandle> create(WebCore::CSSStyleDeclaration&); > > This isn’t implemented anywhere? Oops. I will remove it.
Anders Carlsson
Comment 5 2014-12-05 10:29:43 PST
Committed r176849: <http://trac.webkit.org/changeset/176849>
Note You need to log in before you can comment on or make changes to this bug.