| Summary: | Fix style sharing with the "type" and "readonly" attributes | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Benjamin Poulain <benjamin> | ||||
| Component: | New Bugs | Assignee: | Benjamin Poulain <benjamin> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | jeffrey+webkit, kling, koivisto, mikey.m, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Benjamin Poulain
2014-12-04 19:43:46 PST
Created attachment 242612 [details]
Patch
Comment on attachment 242612 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=242612&action=review > Source/WebCore/css/RuleSet.cpp:105 > +static bool containsUncommonAttributeSelector(const CSSSelector& rootSelector, bool startsOnRightmostElement) Before landing I should rename this boolean. startsOnRightmostElement->matchesRightmostElement Comment on attachment 242612 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=242612&action=review > Source/WebCore/css/RuleSet.cpp:111 > + // It is a very aggressive solution which disable a lot of style sharing on pages that rely on attributes for styling. seems more 'primitive' than 'aggressive' Committed r176864: <http://trac.webkit.org/changeset/176864> *** Bug 123239 has been marked as a duplicate of this bug. *** *** Bug 119000 has been marked as a duplicate of this bug. *** |