Bug 139283

Summary: Fix style sharing with the "type" and "readonly" attributes
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: jeffrey+webkit, kling, koivisto, mikey.m, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch koivisto: review+

Benjamin Poulain
Reported 2014-12-04 19:43:46 PST
Fix style sharing with the "type" and "readonly" attributes
Attachments
Patch (102.75 KB, patch)
2014-12-04 20:04 PST, Benjamin Poulain 		koivisto: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2014-12-04 20:04:04 PST
Created attachment 242612 [details] Patch
Benjamin Poulain
Comment 2 2014-12-04 20:14:16 PST
Comment on attachment 242612 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=242612&action=review > Source/WebCore/css/RuleSet.cpp:105 > +static bool containsUncommonAttributeSelector(const CSSSelector& rootSelector, bool startsOnRightmostElement) Before landing I should rename this boolean. startsOnRightmostElement->matchesRightmostElement
Antti Koivisto
Comment 3 2014-12-05 12:50:43 PST
Comment on attachment 242612 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=242612&action=review > Source/WebCore/css/RuleSet.cpp:111 > + // It is a very aggressive solution which disable a lot of style sharing on pages that rely on attributes for styling. seems more 'primitive' than 'aggressive'
Benjamin Poulain
Comment 4 2014-12-05 12:57:35 PST
Committed r176864: <http://trac.webkit.org/changeset/176864>
Benjamin Poulain
Comment 5 2015-02-01 17:58:38 PST
*** Bug 123239 has been marked as a duplicate of this bug. ***
Benjamin Poulain
Comment 6 2015-02-01 18:03:11 PST
*** Bug 119000 has been marked as a duplicate of this bug. ***
Tim Nguyen (:ntim)
Comment 7 2023-04-28 21:11:19 PDT
rdar://14643850
Note You need to log in before you can comment on or make changes to this bug.