Bug 139268

Summary:

Web Inspector: Network Timeline Filter Bar only has "All", missing Resource Type filters

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, mattbaker, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Joseph Pecoraro

Reported 2014-12-04 14:06:47 PST

* SUMMARY Network Timeline Filter Bar only has "All", missing Resource Type filters. * STEPS TO REPRODUCE 1. Inspect http://bogojoker.com/shell/ 2. Reload 3. Select a reasonable range in Timeline 4. Select Network Timeline 5. Mouse over Network Table => Filter bar only shows "All" * NOTES - Regressed with r175784 when a dictionary object changed to a map.

Attachments
[PATCH] Proposed Fix (2.06 KB, patch) 2014-12-04 14:08 PST, Joseph Pecoraro	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2014-12-04 14:07:08 PST

<rdar://problem/19148493>

Joseph Pecoraro

Comment 2 2014-12-04 14:08:12 PST

Created attachment 242586 [details] [PATCH] Proposed Fix

Joseph Pecoraro

Comment 3 2014-12-04 14:10:06 PST

Actually... Why even make these a Map just for the purpose of this? I'll just revert it back to what it was using.

Joseph Pecoraro

Comment 4 2014-12-04 14:12:00 PST

Comment on attachment 242586 [details] [PATCH] Proposed Fix Nevermind, I see the reason why. The values are not straight values, they use displayNameForEventType. Back to r?.

WebKit Commit Bot

Comment 5 2014-12-04 14:55:32 PST

Comment on attachment 242586 [details] [PATCH] Proposed Fix Clearing flags on attachment: 242586 Committed r176819: <http://trac.webkit.org/changeset/176819>

WebKit Commit Bot

Comment 6 2014-12-04 14:55:36 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.