Bug 139268

Summary:

Web Inspector: Network Timeline Filter Bar only has "All", missing Resource Type filters

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, mattbaker, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Description Joseph Pecoraro 2014-12-04 14:06:47 PST

* SUMMARY
Network Timeline Filter Bar only has "All", missing Resource Type filters.

* STEPS TO REPRODUCE
1. Inspect http://bogojoker.com/shell/
2. Reload
3. Select a reasonable range in Timeline
4. Select Network Timeline
5. Mouse over Network Table
  => Filter bar only shows "All"

* NOTES
- Regressed with r175784 when a dictionary object changed to a map.

Comment 1 Radar WebKit Bug Importer 2014-12-04 14:07:08 PST

<rdar://problem/19148493>

Comment 2 Joseph Pecoraro 2014-12-04 14:08:12 PST

Created attachment 242586 [details]
[PATCH] Proposed Fix

Comment 3 Joseph Pecoraro 2014-12-04 14:10:06 PST

Actually... Why even make these a Map just for the purpose of this? I'll just revert it back to what it was using.

Comment 4 Joseph Pecoraro 2014-12-04 14:12:00 PST

Comment on attachment 242586 [details]
[PATCH] Proposed Fix

Nevermind, I see the reason why. The values are not straight values, they use displayNameForEventType. Back to r?.

Comment 5 WebKit Commit Bot 2014-12-04 14:55:32 PST

Comment on attachment 242586 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 242586

Committed r176819: <http://trac.webkit.org/changeset/176819>

Comment 6 WebKit Commit Bot 2014-12-04 14:55:36 PST

All reviewed patches have been landed.  Closing bug.