Bug 139268 - Web Inspector: Network Timeline Filter Bar only has "All", missing Resource Type filters
Summary: Web Inspector: Network Timeline Filter Bar only has "All", missing Resource T...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-12-04 14:06 PST by Joseph Pecoraro
Modified: 2014-12-04 14:55 PST (History)
6 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (2.06 KB, patch)
2014-12-04 14:08 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-12-04 14:06:47 PST 
* SUMMARY
Network Timeline Filter Bar only has "All", missing Resource Type filters.

* STEPS TO REPRODUCE
1. Inspect http://bogojoker.com/shell/
2. Reload
3. Select a reasonable range in Timeline
4. Select Network Timeline
5. Mouse over Network Table
  => Filter bar only shows "All"

* NOTES
- Regressed with r175784 when a dictionary object changed to a map.
Comment 1 Radar WebKit Bug Importer 2014-12-04 14:07:08 PST 
<rdar://problem/19148493>
Comment 2 Joseph Pecoraro 2014-12-04 14:08:12 PST 
Created attachment 242586 [details]
[PATCH] Proposed Fix
Comment 3 Joseph Pecoraro 2014-12-04 14:10:06 PST 
Actually... Why even make these a Map just for the purpose of this? I'll just revert it back to what it was using.
Comment 4 Joseph Pecoraro 2014-12-04 14:12:00 PST 
Comment on attachment 242586 [details]
[PATCH] Proposed Fix

Nevermind, I see the reason why. The values are not straight values, they use displayNameForEventType. Back to r?.
Comment 5 WebKit Commit Bot 2014-12-04 14:55:32 PST 
Comment on attachment 242586 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 242586

Committed r176819: <http://trac.webkit.org/changeset/176819>
Comment 6 WebKit Commit Bot 2014-12-04 14:55:36 PST 
All reviewed patches have been landed.  Closing bug.