Bug 139264

Summary: Don't lock perf tests in run-webkit-tests
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, glenn, ossy, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=136722
Attachments:
Description Flags
proposed patch dbates: review+

Alexey Proskuryakov
Reported 2014-12-04 12:10:42 PST
We have some code that "locks" tests in LayoutTests/perf, because they are timing sensitive, and would like to run on a separate thread. But this code is broken in several ways: 1. It doesn't do anything, because LayoutTests/perf is a leaf directory, and all these tests run sequentially even without locking. 2. It doesn't prevent other tests from running at the same time, so we have the timing problems that we were trying to avoid. 3. The locking code is tangled with code that starts and stops httpd, which is just incorrect, and very confusing. As a result, perf tests are skipped on Mac entirely. I'd like to remove the code, and if someone wants to revive the tests, a new correct solution should be found. Ossy suggested running these tests as a separate step, which makes sense to me, but would complicate error reporting on buildbot and EWS.
Attachments
proposed patch (12.40 KB, patch)
2014-12-04 12:15 PST, Alexey Proskuryakov 		dbates: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2014-12-04 12:15:40 PST
Created attachment 242580 [details] proposed patch
Daniel Bates
Comment 2 2014-12-04 13:45:00 PST
Comment on attachment 242580 [details] proposed patch rs=me
Alexey Proskuryakov
Comment 3 2014-12-04 13:49:23 PST
Committed <http://trac.webkit.org/r176814>.
Note You need to log in before you can comment on or make changes to this bug.