Bug 139252

Summary: TextIndicator::createWithSelectionInFrame does synchronous IPC in WebKit2
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, commit-queue, mitz, sam, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch andersca: review+

Tim Horton
Reported 2014-12-04 00:55:15 PST
TextIndicator::createWithSelectionInFrame does synchronous IPC in WebKit2
Attachments
Patch (17.14 KB, patch)
2014-12-04 00:56 PST, Tim Horton 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2014-12-04 00:56:22 PST
Created attachment 242556 [details] Patch
Radar WebKit Bug Importer
Comment 2 2014-12-04 00:57:04 PST
<rdar://problem/19140827>
WebKit Commit Bot
Comment 3 2014-12-04 00:57:51 PST
Attachment 242556 [details] did not pass style-queue: ERROR: Source/WebCore/page/mac/TextIndicatorWindow.mm:269: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/page/mac/TextIndicatorWindow.h:51: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 4 2014-12-04 11:58:08 PST
http://trac.webkit.org/changeset/176810
Tim Horton
Comment 5 2014-12-04 13:10:49 PST
And http://trac.webkit.org/changeset/176811
Tim Horton
Comment 6 2014-12-04 13:32:10 PST
And http://trac.webkit.org/changeset/176812
Note You need to log in before you can comment on or make changes to this bug.