Bug 139252

Summary: TextIndicator::createWithSelectionInFrame does synchronous IPC in WebKit2
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, commit-queue, mitz, sam, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch andersca: review+

Description Tim Horton 2014-12-04 00:55:15 PST
TextIndicator::createWithSelectionInFrame does synchronous IPC in WebKit2
Comment 1 Tim Horton 2014-12-04 00:56:22 PST
Created attachment 242556 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2014-12-04 00:57:04 PST
<rdar://problem/19140827>
Comment 3 WebKit Commit Bot 2014-12-04 00:57:51 PST
Attachment 242556 [details] did not pass style-queue:


ERROR: Source/WebCore/page/mac/TextIndicatorWindow.mm:269:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/mac/TextIndicatorWindow.h:51:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Tim Horton 2014-12-04 11:58:08 PST
http://trac.webkit.org/changeset/176810
Comment 5 Tim Horton 2014-12-04 13:10:49 PST
And http://trac.webkit.org/changeset/176811
Comment 6 Tim Horton 2014-12-04 13:32:10 PST
And http://trac.webkit.org/changeset/176812