Bug 139252 - TextIndicator::createWithSelectionInFrame does synchronous IPC in WebKit2
Summary: TextIndicator::createWithSelectionInFrame does synchronous IPC in WebKit2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-12-04 00:55 PST by Tim Horton
Modified: 2014-12-04 13:32 PST (History)
7 users (show)

See Also:

Attachments
Patch (17.14 KB, patch)
2014-12-04 00:56 PST, Tim Horton 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-12-04 00:55:15 PST 
TextIndicator::createWithSelectionInFrame does synchronous IPC in WebKit2
Comment 1 Tim Horton 2014-12-04 00:56:22 PST 
Created attachment 242556 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2014-12-04 00:57:04 PST 
<rdar://problem/19140827>
Comment 3 WebKit Commit Bot 2014-12-04 00:57:51 PST 
Attachment 242556 [details] did not pass style-queue:


ERROR: Source/WebCore/page/mac/TextIndicatorWindow.mm:269:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/mac/TextIndicatorWindow.h:51:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Tim Horton 2014-12-04 11:58:08 PST 
http://trac.webkit.org/changeset/176810
Comment 5 Tim Horton 2014-12-04 13:10:49 PST 
And http://trac.webkit.org/changeset/176811
Comment 6 Tim Horton 2014-12-04 13:32:10 PST 
And http://trac.webkit.org/changeset/176812