| Summary: | <input> elements get whitespace action menu instead of editable text menu | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Beth Dakin <bdakin> | ||||
| Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bdakin, commit-queue, esprehn+autocc, glenn, kondapallykalyan, thorton | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Beth Dakin
2014-12-03 16:38:03 PST
Created attachment 242539 [details]
Patch
Attachment 242539 [details] did not pass style-queue:
ERROR: Source/WebCore/rendering/HitTestResult.cpp:544: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 1 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 242539 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=242539&action=review > Source/WebKit2/Shared/WebHitTestResult.h:57 > bool isTextNode; > + bool isOverTextInsideFormControlElement; I would prefer to see isTextNode and isOverTextInsideFormControlElement combined into a single isText (or maybe isOverText), since that is how it is used. Thanks Sam! Tim and I talked it over, and we both think that isText/isOverText is misleading since it would not return true every single time you were over text. isTextNode() and isOverTextInsideFormControlElement() are both very specific questions that we can answer properly. |