| Summary: | Remove isSpecifiedFont boolean from FontDescription | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||||
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | REOPENED --- | ||||||||||
| Severity: | Normal | CC: | buildbot, commit-queue, ossy, rniwa, stavila | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | 139255 | ||||||||||
| Bug Blocks: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Antti Koivisto
2014-12-03 13:44:23 PST
Created attachment 242521 [details]
patch
Comment on attachment 242521 [details] patch Attachment 242521 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6378789420400640 New failing tests: fast/text/backslash-to-yen-sign-euc.html editing/selection/find-yensign-and-backslash.html Created attachment 242527 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 242521 [details] patch Attachment 242521 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5170800340500480 New failing tests: fast/text/backslash-to-yen-sign-euc.html editing/selection/find-yensign-and-backslash.html Created attachment 242532 [details]
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-02 Port: mac-mountainlion Platform: Mac OS X 10.8.5
https://trac.webkit.org/r176789 (with system font fix) (In reply to comment #6) > https://trac.webkit.org/r176789 (with system font fix) It broke the non Apple builds (not in WebKit2!), plese fix it. lib/libwebcore_efl.a(lib/../Source/WebCore/CMakeFiles/WebCore.dir/rendering/RenderText.cpp.o):RenderText.cpp:function WebCore::RenderText::computeUseBackslashAsYenSymbol() const: error: undefined reference to 'WebCore::Font::primaryFontDataIsSystemFont() const' collect2: error: ld returned 1 exit status primaryFontDataIsSystemFont() is a Mac only thing in FontMac.mm. And it seems the reviewed and the landed patch is completely different. Re-opened since this is blocked by bug 139255 |