Bug 139228

Summary: Web Inspector: Missing getter, clients never see DragToAdjustController is enabled
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, msaboff, simon.fraser, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2014-12-03 11:15:22 PST
* SUMMARY DragToAdjustController has a setter but no getter for "enabled", yet CodeMirrorDragToAdjustNumberController tries to use it. The result is always undefined and can cause unnecessary duplicated work.
Attachments
[PATCH] Proposed Fix (1.32 KB, patch)
2014-12-03 11:16 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-12-03 11:15:47 PST
<rdar://problem/19131615>
Radar WebKit Bug Importer
Comment 2 2014-12-03 11:15:47 PST
<rdar://problem/19131616>
Joseph Pecoraro
Comment 3 2014-12-03 11:16:12 PST
Created attachment 242507 [details] [PATCH] Proposed Fix
Michael Saboff
Comment 4 2014-12-03 11:21:24 PST
Comment on attachment 242507 [details] [PATCH] Proposed Fix r=me
Joseph Pecoraro
Comment 5 2014-12-03 16:57:06 PST
Could you flip the r+ flag? That'll get this landing =)
WebKit Commit Bot
Comment 6 2014-12-03 17:39:53 PST
Comment on attachment 242507 [details] [PATCH] Proposed Fix Clearing flags on attachment: 242507 Committed r176770: <http://trac.webkit.org/changeset/176770>
WebKit Commit Bot
Comment 7 2014-12-03 17:39:57 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.