Summary: | Modernize the CSSParser code | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
Component: | CSS | Assignee: | Chris Dumez <cdumez> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | benjamin, commit-queue, darin, kling, koivisto, ossy | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Chris Dumez
2014-12-02 16:21:40 PST
Created attachment 242465 [details]
Patch
Comment on attachment 242465 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=242465&action=review > Source/WebCore/css/CSSParser.cpp:5966 > + for (CSSParserValue* argument = args.current(); argument; argument = args.next()) { > // The call to parseFillPosition below should consume all of the > // arguments except the first three. Thus, an index greater than two > // indicates an invalid production. > - if (args->currentIndex() > 2) > + if (args.currentIndex() > 2) > return nullptr; The stateful iteration of CSSParserValueList is bit strange. Wonder if it could just be a vector... Comment on attachment 242465 [details] Patch Clearing flags on attachment: 242465 Committed r176719: <http://trac.webkit.org/changeset/176719> All reviewed patches have been landed. Closing bug. (In reply to comment #3) > Comment on attachment 242465 [details] > Patch > > Clearing flags on attachment: 242465 > > Committed r176719: <http://trac.webkit.org/changeset/176719> And the trivial buildfix landed in https://trac.webkit.org/changeset/176722. (unfortunately with wrong reference to the changeset) But it was super easy and EWS noticed it in time. :-/ |