Bug 139196

Summary: operationPutById's can potentially generate code for an out of date structure
Product: WebKit Reporter: Matthew Mirman <mmirman>
Component: JavaScriptCoreAssignee: Matthew Mirman <mmirman>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, fpizlo, ggaren, kling, mmirman
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 139424    
Bug Blocks:    
Attachments:
Description Flags
operationPutByIds fix
none
operationPutByIds fix none

Matthew Mirman
Reported 2014-12-02 14:07:50 PST
Similar to how operationGetByIdBuildList could have done so as seen in https://bugs.webkit.org/show_bug.cgi?id=136961 The fix will be different since the slot can not be generated separately from the put. Patch forthcoming.
Attachments
operationPutByIds fix (10.05 KB, patch)
2014-12-02 14:40 PST, Matthew Mirman 		no flags
DetailsFormatted DiffDiff
operationPutByIds fix (11.15 KB, patch)
2014-12-04 13:35 PST, Matthew Mirman 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Matthew Mirman
Comment 1 2014-12-02 14:40:07 PST
Created attachment 242451 [details] operationPutByIds fix
Filip Pizlo
Comment 2 2014-12-02 14:47:34 PST
Comment on attachment 242451 [details] operationPutByIds fix Can you add a test that would fail without your patch?
Matthew Mirman
Comment 3 2014-12-04 13:35:46 PST
Created attachment 242584 [details] operationPutByIds fix Adds a test that fails without the patch.
WebKit Commit Bot
Comment 4 2014-12-08 15:10:48 PST
Comment on attachment 242584 [details] operationPutByIds fix Clearing flags on attachment: 242584 Committed r176979: <http://trac.webkit.org/changeset/176979>
WebKit Commit Bot
Comment 5 2014-12-08 15:10:52 PST
All reviewed patches have been landed. Closing bug.
Dean Jackson
Comment 6 2014-12-08 17:02:03 PST
I think this broke some JS tests: https://build.webkit.org/builders/Apple%20Yosemite%20Release%20WK2%20%28Tests%29/builds/1158
WebKit Commit Bot
Comment 7 2014-12-08 17:21:40 PST
Re-opened since this is blocked by bug 139424
Matthew Mirman
Comment 8 2014-12-10 11:40:42 PST
Committed a patch similar to the reviewed patch https://bug-139196-attachments.webkit.org/attachment.cgi?id=242584 but without the failing test. Committed r176979: http://trac.webkit.org/changeset/177083
Matthew Mirman
Comment 9 2014-12-10 11:59:13 PST
Test added from the patch https://bugs.webkit.org/attachment.cgi?id=242584&action=edit is now included in <https://bugs.webkit.org/show_bug.cgi?id=139500>
Note You need to log in before you can comment on or make changes to this bug.