Bug 139147 – Twitter avatar moves when hovering/unhovering the "follow" button.

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[zalan]

1. Sign into twitter
2. follow @xctotd
3. load https://twitter.com/intent/user?screen_name=xctotd
4. Now hover/unhover the "Following" button. 

Every time you do, the Xcode icon moves up a bit.

[zalan]

related to http://trac.webkit.org/changeset/81643

[zalan]

rdar://problem/19096508

[zalan]

Created attachment 242336 [details]
Patch

[zalan]

Created attachment 242337 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 242337 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242337&action=review

> Source/WebCore/ChangeLog:13
> +        subtree in block direction, the out of flow positioned boxes are not yet taken off of the line.

"in the block direction"
"taken off of the line": not sure what this means.

> Source/WebCore/ChangeLog:14
> +        They are getting removed later at RenderBlockFlow::computeBlockDirectionPositionsForLine().

will get removed?

> LayoutTests/fast/inline/out-of-flow-positioned-render-replaced-box-moves.html:32
> +     }, 100);

100ms, really? Can't this all be made synchronous with offsetWidth?

[zalan]

Created attachment 242354 [details]
Patch

[zalan]

(In reply to comment #5)
> Comment on attachment 242337 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=242337&action=review
> 
> > Source/WebCore/ChangeLog:13
> > +        subtree in block direction, the out of flow positioned boxes are not yet taken off of the line.
> 
> "in the block direction"
> "taken off of the line": not sure what this means.
> 
> > Source/WebCore/ChangeLog:14
> > +        They are getting removed later at RenderBlockFlow::computeBlockDirectionPositionsForLine().
> 
> will get removed?
> 
Rephrased.

> > LayoutTests/fast/inline/out-of-flow-positioned-render-replaced-box-moves.html:32
> > +     }, 100);
> 
> 100ms, really? Can't this all be made synchronous with offsetWidth?
Unfortunately not. I managed to make it to 10ms though.

[WebKit Commit Bot]

Comment on attachment 242354 [details]
Patch

Clearing flags on attachment: 242354

Committed r176619: <http://trac.webkit.org/changeset/176619>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.