Bug 139147

Summary: Twitter avatar moves when hovering/unhovering the "follow" button.
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, hyatt, inferno, kondapallykalyan, mmaxfield, simon.fraser
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description zalan 2014-12-01 12:58:42 PST 
1. Sign into twitter
2. follow @xctotd
3. load https://twitter.com/intent/user?screen_name=xctotd
4. Now hover/unhover the "Following" button. 

Every time you do, the Xcode icon moves up a bit.
Comment 1 zalan 2014-12-01 13:00:08 PST 
related to http://trac.webkit.org/changeset/81643
Comment 2 zalan 2014-12-01 13:00:48 PST 
rdar://problem/19096508
Comment 3 zalan 2014-12-01 13:23:21 PST 
Created attachment 242336 [details]
Patch
Comment 4 zalan 2014-12-01 13:24:16 PST 
Created attachment 242337 [details]
Patch
Comment 5 Simon Fraser (smfr) 2014-12-01 13:28:37 PST 
Comment on attachment 242337 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242337&action=review

> Source/WebCore/ChangeLog:13
> +        subtree in block direction, the out of flow positioned boxes are not yet taken off of the line.

"in the block direction"
"taken off of the line": not sure what this means.

> Source/WebCore/ChangeLog:14
> +        They are getting removed later at RenderBlockFlow::computeBlockDirectionPositionsForLine().

will get removed?

> LayoutTests/fast/inline/out-of-flow-positioned-render-replaced-box-moves.html:32
> +     }, 100);

100ms, really? Can't this all be made synchronous with offsetWidth?
Comment 6 zalan 2014-12-01 15:16:30 PST 
Created attachment 242354 [details]
Patch
Comment 7 zalan 2014-12-01 15:17:53 PST 
(In reply to comment #5)
> Comment on attachment 242337 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=242337&action=review
> 
> > Source/WebCore/ChangeLog:13
> > +        subtree in block direction, the out of flow positioned boxes are not yet taken off of the line.
> 
> "in the block direction"
> "taken off of the line": not sure what this means.
> 
> > Source/WebCore/ChangeLog:14
> > +        They are getting removed later at RenderBlockFlow::computeBlockDirectionPositionsForLine().
> 
> will get removed?
> 
Rephrased.

> > LayoutTests/fast/inline/out-of-flow-positioned-render-replaced-box-moves.html:32
> > +     }, 100);
> 
> 100ms, really? Can't this all be made synchronous with offsetWidth?
Unfortunately not. I managed to make it to 10ms though.
Comment 8 WebKit Commit Bot 2014-12-01 17:59:12 PST 
Comment on attachment 242354 [details]
Patch

Clearing flags on attachment: 242354

Committed r176619: <http://trac.webkit.org/changeset/176619>
Comment 9 WebKit Commit Bot 2014-12-01 17:59:16 PST 
All reviewed patches have been landed.  Closing bug.