Bug 139139

Summary: [MSE] Fix not always calling mediaPlayer seek.
Product: WebKit Reporter: Bartlomiej Gajda <b.gajda>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, commit-queue, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, ltilve, philipj, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
always notifying of seek with mse none

Description Bartlomiej Gajda 2014-12-01 11:28:45 PST
Change : https://bugs.webkit.org/show_bug.cgi?id=118752

unrightfully changed :

-    if (m_mediaSource && m_mediaSource->readyState() != MediaSource::closedKeyword())
+    if (m_mediaSource && m_mediaSource->isClosed())

but the whole sense of this is that if media source is not closed, then it should always call m_player->seek, and so on. (even comment says so)

Second expression should be negated.
Comment 1 Bartlomiej Gajda 2014-12-01 11:31:15 PST
Created attachment 242323 [details]
always notifying of seek with mse


Not sure can this behavior be tested using MockMediaSource, as events are going in (but it we would printf() in middle of seek function, and seek to currentTime(), it would not go)
Comment 2 WebKit Commit Bot 2014-12-01 14:04:10 PST
Comment on attachment 242323 [details]
always notifying of seek with mse

Clearing flags on attachment: 242323

Committed r176604: <http://trac.webkit.org/changeset/176604>
Comment 3 WebKit Commit Bot 2014-12-01 14:04:15 PST
All reviewed patches have been landed.  Closing bug.