Bug 139139 - [MSE] Fix not always calling mediaPlayer seek.
Summary: [MSE] Fix not always calling mediaPlayer seek.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-01 11:28 PST by Bartlomiej Gajda
Modified: 2014-12-02 01:42 PST (History)
10 users (show)

See Also:

Attachments
always notifying of seek with mse (1.33 KB, patch)
2014-12-01 11:31 PST, Bartlomiej Gajda 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bartlomiej Gajda 2014-12-01 11:28:45 PST 
Change : https://bugs.webkit.org/show_bug.cgi?id=118752

unrightfully changed :

-    if (m_mediaSource && m_mediaSource->readyState() != MediaSource::closedKeyword())
+    if (m_mediaSource && m_mediaSource->isClosed())

but the whole sense of this is that if media source is not closed, then it should always call m_player->seek, and so on. (even comment says so)

Second expression should be negated.
Comment 1 Bartlomiej Gajda 2014-12-01 11:31:15 PST 
Created attachment 242323 [details]
always notifying of seek with mse


Not sure can this behavior be tested using MockMediaSource, as events are going in (but it we would printf() in middle of seek function, and seek to currentTime(), it would not go)
Comment 2 WebKit Commit Bot 2014-12-01 14:04:10 PST 
Comment on attachment 242323 [details]
always notifying of seek with mse

Clearing flags on attachment: 242323

Committed r176604: <http://trac.webkit.org/changeset/176604>
Comment 3 WebKit Commit Bot 2014-12-01 14:04:15 PST 
All reviewed patches have been landed.  Closing bug.