Bug 139096

Summary: PropertyTable keys should be AtomicStringImpl.
Product: WebKit Reporter: Andreas Kling <kling>
Component: JavaScriptCoreAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: kling
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Andreas Kling
Reported 2014-11-28 23:36:39 PST
Since JSC::PropertyTable keys are always Identifiers, the table should use AtomicStringImpl* rather than StringImpl* for its key type. Any instance of a non-atomic StringImpl* in a PropertyTable would be a bug.
Attachments
Patch (28.19 KB, patch)
2014-11-28 23:41 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2014-11-28 23:41:06 PST
Created attachment 242273 [details] Patch
Andreas Kling
Comment 2 2014-11-29 16:06:34 PST
Comment on attachment 242273 [details] Patch Clearing flags on attachment: 242273 Committed r176583: <http://trac.webkit.org/changeset/176583>
Andreas Kling
Comment 3 2014-11-29 16:06:37 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.