Bug 139096

Summary: PropertyTable keys should be AtomicStringImpl.
Product: WebKit Reporter: Andreas Kling <kling>
Component: JavaScriptCoreAssignee: Andreas Kling <kling>
Severity: Normal CC: kling
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch none

Description Andreas Kling 2014-11-28 23:36:39 PST
Since JSC::PropertyTable keys are always Identifiers, the table should use AtomicStringImpl* rather than StringImpl* for its key type.
Any instance of a non-atomic StringImpl* in a PropertyTable would be a bug.
Comment 1 Andreas Kling 2014-11-28 23:41:06 PST
Created attachment 242273 [details]
Comment 2 Andreas Kling 2014-11-29 16:06:34 PST
Comment on attachment 242273 [details]

Clearing flags on attachment: 242273

Committed r176583: <http://trac.webkit.org/changeset/176583>
Comment 3 Andreas Kling 2014-11-29 16:06:37 PST
All reviewed patches have been landed.  Closing bug.