Bug 13909

Summary: SVG text selection doesn't work with RTL text
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: SVGAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal CC: oliver
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: Macintosh   
OS: OS X 10.4   
Attachments:
Description Flags
Initial patch
oliver: review+
New test results oliver: review+

Description Nikolas Zimmermann 2007-05-29 14:04:12 PDT
Naturual behaviour of RTL text selection is broken in the new SVG text engine.
It never worked perfectly - now it's time to fix it for real.
Comment 1 Nikolas Zimmermann 2007-08-07 15:22:36 PDT
Created attachment 15858 [details]
Initial patch

This introduces SVG RTL & BiDi text selection in feature-branch.
Comment 2 Nikolas Zimmermann 2007-08-07 15:28:46 PDT
Created attachment 15859 [details]
New test results

LayoutTests/ changes.
Comment 3 Oliver Hunt 2007-08-07 15:49:52 PDT
Comment on attachment 15858 [details]
Initial patch

I would prefer it if 
int offset = !textBox->m_reversed ? textBox->start() + i : textBox->end() - i;

was instead
int offset = textBox->m_reversed ? textBox->end() - i : textBox->start() + i;
Comment 4 Oliver Hunt 2007-08-07 16:09:34 PDT
Comment on attachment 15859 [details]
New test results

Layout tests seem fine
Comment 5 Nikolas Zimmermann 2007-08-07 16:14:28 PDT
Landed in r24916.