Bug 13909 - SVG text selection doesn't work with RTL text
Summary: SVG text selection doesn't work with RTL text
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 523.x (Safari 3)
Hardware: Macintosh OS X 10.4
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-05-29 14:04 PDT by Nikolas Zimmermann
Modified: 2007-08-07 16:14 PDT (History)
1 user (show)

See Also:


Attachments
Initial patch (27.18 KB, patch)
2007-08-07 15:22 PDT, Nikolas Zimmermann
oliver: review+
Details | Formatted Diff | Diff
New test results (150.68 KB, patch)
2007-08-07 15:28 PDT, Nikolas Zimmermann
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2007-05-29 14:04:12 PDT
Naturual behaviour of RTL text selection is broken in the new SVG text engine.
It never worked perfectly - now it's time to fix it for real.
Comment 1 Nikolas Zimmermann 2007-08-07 15:22:36 PDT
Created attachment 15858 [details]
Initial patch

This introduces SVG RTL & BiDi text selection in feature-branch.
Comment 2 Nikolas Zimmermann 2007-08-07 15:28:46 PDT
Created attachment 15859 [details]
New test results

LayoutTests/ changes.
Comment 3 Oliver Hunt 2007-08-07 15:49:52 PDT
Comment on attachment 15858 [details]
Initial patch

I would prefer it if 
int offset = !textBox->m_reversed ? textBox->start() + i : textBox->end() - i;

was instead
int offset = textBox->m_reversed ? textBox->end() - i : textBox->start() + i;
Comment 4 Oliver Hunt 2007-08-07 16:09:34 PDT
Comment on attachment 15859 [details]
New test results

Layout tests seem fine
Comment 5 Nikolas Zimmermann 2007-08-07 16:14:28 PDT
Landed in r24916.