Bug 139080

Summary: [WK2] SecComp buildfix after r168605 and r168999
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, cgarcia, commit-queue, gyuyoung.kim, ossy, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 132808, 133033    
Attachments:
Description Flags
Patch none

Csaba Osztrogonác
Reported 2014-11-27 13:36:33 PST
https://trac.webkit.org/changeset/168605 removed localStorageDirectory from WebProcessCreationParameters and https://trac.webkit.org/changeset/168999 renamed databaseDirectory to webSQLDatabaseDirectory. ../../Source/WebKit2/Shared/linux/SeccompFilters/SyscallPolicy.cpp:121:21: error: no member named 'databaseDirectory' in 'WebKit::WebProcessCreationParameters' if (!parameters.databaseDirectory.isEmpty()) ~~~~~~~~~~ ^ ../../Source/WebKit2/Shared/linux/SeccompFilters/SyscallPolicy.cpp:122:63: error: no member named 'databaseDirectory' in 'WebKit::WebProcessCreationParameters' addDirectoryPermission(removeTrailingSlash(parameters.databaseDirectory), ReadAndWrite); ~~~~~~~~~~ ^ ../../Source/WebKit2/Shared/linux/SeccompFilters/SyscallPolicy.cpp:123:21: error: no member named 'localStorageDirectory' in 'WebKit::WebProcessCreationParameters'; did you mean 'cookieStorageDirectory'? if (!parameters.localStorageDirectory.isEmpty()) ^~~~~~~~~~~~~~~~~~~~~ cookieStorageDirectory ../../Source/WebKit2/Shared/WebProcessCreationParameters.h:73:12: note: 'cookieStorageDirectory' declared here String cookieStorageDirectory; ^ ../../Source/WebKit2/Shared/linux/SeccompFilters/SyscallPolicy.cpp:124:63: error: no member named 'localStorageDirectory' in 'WebKit::WebProcessCreationParameters'; did you mean 'cookieStorageDirectory'? addDirectoryPermission(removeTrailingSlash(parameters.localStorageDirectory), ReadAndWrite); ^~~~~~~~~~~~~~~~~~~~~ cookieStorageDirectory ../../Source/WebKit2/Shared/WebProcessCreationParameters.h:73:12: note: 'cookieStorageDirectory' declared here String cookieStorageDirectory; ^ 1 warning and 4 errors generated.
Attachments
Patch (2.01 KB, patch)
2014-11-27 13:44 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2014-11-27 13:44:35 PST
Created attachment 242257 [details] Patch
WebKit Commit Bot
Comment 2 2014-11-28 01:04:01 PST
Comment on attachment 242257 [details] Patch Clearing flags on attachment: 242257 Committed r176557: <http://trac.webkit.org/changeset/176557>
WebKit Commit Bot
Comment 3 2014-11-28 01:04:06 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.