Bug 139080

Summary:

[WK2] SecComp buildfix after r168605 and r168999

Product:

WebKit

Reporter:

Csaba Osztrogonác <ossy>

Component:

New Bugs

Assignee:

Csaba Osztrogonác <ossy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, bdakin, cgarcia, commit-queue, gyuyoung.kim, ossy, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

132808, 133033

Attachments:

Description	Flags
Patch	none

Description Csaba Osztrogonác 2014-11-27 13:36:33 PST

https://trac.webkit.org/changeset/168605 removed localStorageDirectory from WebProcessCreationParameters 
and https://trac.webkit.org/changeset/168999 renamed databaseDirectory to webSQLDatabaseDirectory. 

../../Source/WebKit2/Shared/linux/SeccompFilters/SyscallPolicy.cpp:121:21: error: no member named 'databaseDirectory' in 'WebKit::WebProcessCreationParameters'
    if (!parameters.databaseDirectory.isEmpty())
         ~~~~~~~~~~ ^
../../Source/WebKit2/Shared/linux/SeccompFilters/SyscallPolicy.cpp:122:63: error: no member named 'databaseDirectory' in 'WebKit::WebProcessCreationParameters'
        addDirectoryPermission(removeTrailingSlash(parameters.databaseDirectory), ReadAndWrite);
                                                   ~~~~~~~~~~ ^
../../Source/WebKit2/Shared/linux/SeccompFilters/SyscallPolicy.cpp:123:21: error: no member named 'localStorageDirectory' in 'WebKit::WebProcessCreationParameters'; did you mean 'cookieStorageDirectory'?
    if (!parameters.localStorageDirectory.isEmpty())
                    ^~~~~~~~~~~~~~~~~~~~~
                    cookieStorageDirectory
../../Source/WebKit2/Shared/WebProcessCreationParameters.h:73:12: note: 'cookieStorageDirectory' declared here
    String cookieStorageDirectory;
           ^
../../Source/WebKit2/Shared/linux/SeccompFilters/SyscallPolicy.cpp:124:63: error: no member named 'localStorageDirectory' in 'WebKit::WebProcessCreationParameters'; did you mean 'cookieStorageDirectory'?
        addDirectoryPermission(removeTrailingSlash(parameters.localStorageDirectory), ReadAndWrite);
                                                              ^~~~~~~~~~~~~~~~~~~~~
                                                              cookieStorageDirectory
../../Source/WebKit2/Shared/WebProcessCreationParameters.h:73:12: note: 'cookieStorageDirectory' declared here
    String cookieStorageDirectory;
           ^
1 warning and 4 errors generated.

Comment 1 Csaba Osztrogonác 2014-11-27 13:44:35 PST

Created attachment 242257 [details]
Patch

Comment 2 WebKit Commit Bot 2014-11-28 01:04:01 PST

Comment on attachment 242257 [details]
Patch

Clearing flags on attachment: 242257

Committed r176557: <http://trac.webkit.org/changeset/176557>

Comment 3 WebKit Commit Bot 2014-11-28 01:04:06 PST

All reviewed patches have been landed.  Closing bug.