Bug 139080 - [WK2] SecComp buildfix after r168605 and r168999
Summary: [WK2] SecComp buildfix after r168605 and r168999
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks: 132808 133033
  Show dependency tree / graph
 
Reported: 2014-11-27 13:36 PST by Csaba Osztrogonác
Modified: 2014-11-28 01:04 PST (History)
7 users (show)

See Also:

Attachments
Patch (2.01 KB, patch)
2014-11-27 13:44 PST, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2014-11-27 13:36:33 PST 
https://trac.webkit.org/changeset/168605 removed localStorageDirectory from WebProcessCreationParameters 
and https://trac.webkit.org/changeset/168999 renamed databaseDirectory to webSQLDatabaseDirectory. 

../../Source/WebKit2/Shared/linux/SeccompFilters/SyscallPolicy.cpp:121:21: error: no member named 'databaseDirectory' in 'WebKit::WebProcessCreationParameters'
    if (!parameters.databaseDirectory.isEmpty())
         ~~~~~~~~~~ ^
../../Source/WebKit2/Shared/linux/SeccompFilters/SyscallPolicy.cpp:122:63: error: no member named 'databaseDirectory' in 'WebKit::WebProcessCreationParameters'
        addDirectoryPermission(removeTrailingSlash(parameters.databaseDirectory), ReadAndWrite);
                                                   ~~~~~~~~~~ ^
../../Source/WebKit2/Shared/linux/SeccompFilters/SyscallPolicy.cpp:123:21: error: no member named 'localStorageDirectory' in 'WebKit::WebProcessCreationParameters'; did you mean 'cookieStorageDirectory'?
    if (!parameters.localStorageDirectory.isEmpty())
                    ^~~~~~~~~~~~~~~~~~~~~
                    cookieStorageDirectory
../../Source/WebKit2/Shared/WebProcessCreationParameters.h:73:12: note: 'cookieStorageDirectory' declared here
    String cookieStorageDirectory;
           ^
../../Source/WebKit2/Shared/linux/SeccompFilters/SyscallPolicy.cpp:124:63: error: no member named 'localStorageDirectory' in 'WebKit::WebProcessCreationParameters'; did you mean 'cookieStorageDirectory'?
        addDirectoryPermission(removeTrailingSlash(parameters.localStorageDirectory), ReadAndWrite);
                                                              ^~~~~~~~~~~~~~~~~~~~~
                                                              cookieStorageDirectory
../../Source/WebKit2/Shared/WebProcessCreationParameters.h:73:12: note: 'cookieStorageDirectory' declared here
    String cookieStorageDirectory;
           ^
1 warning and 4 errors generated.
Comment 1 Csaba Osztrogonác 2014-11-27 13:44:35 PST 
Created attachment 242257 [details]
Patch
Comment 2 WebKit Commit Bot 2014-11-28 01:04:01 PST 
Comment on attachment 242257 [details]
Patch

Clearing flags on attachment: 242257

Committed r176557: <http://trac.webkit.org/changeset/176557>
Comment 3 WebKit Commit Bot 2014-11-28 01:04:06 PST 
All reviewed patches have been landed.  Closing bug.