| Summary: | Add a Page::setVisitedLinkStore member function | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||
| Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Anders Carlsson
2014-11-26 10:28:29 PST
Created attachment 242233 [details]
Patch
Comment on attachment 242233 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=242233&action=review > Source/WebCore/page/Page.cpp:1648 > +void Page::setVisitedLinkStore(PassRefPtr<VisitedLinkStore> visitedLinkStore) > +{ > + if (m_visitedLinkStore) > + m_visitedLinkStore->removePage(*this); > + > + m_visitedLinkStore = visitedLinkStore; > + > + if (m_visitedLinkStore) > + m_visitedLinkStore->addPage(*this); Do we really want to be to set a null store? Comment on attachment 242233 [details] Patch Rejecting attachment 242233 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 242233, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ', 'dcommit', '--rmdir']" exit_code: 139 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... Authentication realm: <http://svn.webkit.org:80> Mac OS Forge Password for 'commit-queue@webkit.org': Authentication realm: <http://svn.webkit.org:80> Mac OS Forge Username: error: git-svn died of signal 11 Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 139 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource Current branch master is up to date. Full output: http://webkit-queues.appspot.com/results/5904429609910272 Committed r176550: <http://trac.webkit.org/changeset/176550> |