Bug 139037

Summary:

[EFL] REGRESSION(r176514): It made performance tests fail

Product:

WebKit

Reporter:

Csaba Osztrogonác <ossy>

Component:

New Bugs

Assignee:

Csaba Osztrogonác <ossy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, gyuyoung.kim, k.czech, ossy, ryuan.choi

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

137742

Attachments:

Description	Flags
Patch	none
Patch	none

Description Csaba Osztrogonác 2014-11-24 15:54:16 PST

details: https://bugs.webkit.org/show_bug.cgi?id=137742#c23

fix is coming

Comment 1 Csaba Osztrogonác 2014-11-24 16:01:48 PST

Created attachment 242181 [details]
Patch

Comment 2 Krzysztof Czech 2014-11-25 00:40:13 PST

Thanks Ossy for the fix, it's great.

Comment 3 Csaba Osztrogonác 2014-11-25 00:58:49 PST

Created attachment 242189 [details]
Patch

[EFL] prefix added to the changelog

Comment 4 Gyuyoung Kim 2014-11-25 01:20:55 PST

Comment on attachment 242189 [details]
Patch

LGTM.

Comment 5 WebKit Commit Bot 2014-11-25 01:59:22 PST

Comment on attachment 242189 [details]
Patch

Clearing flags on attachment: 242189

Committed r176538: <http://trac.webkit.org/changeset/176538>

Comment 6 WebKit Commit Bot 2014-11-25 01:59:27 PST

All reviewed patches have been landed.  Closing bug.

Comment 7 Krzysztof Czech 2014-11-25 02:12:34 PST

One question. You made some changes to jhbuildrc. Could you tell me when those configurations are used ?.

Comment 8 Csaba Osztrogonác 2014-11-25 04:38:44 PST

Comment on attachment 242189 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242189&action=review

> Tools/efl/jhbuildrc:40
> +if not 'ACCESSIBILITY_EAIL_LIBRARY_PATH' in os.environ:
> +    _libeail_path = os.path.join(os.environ['CMAKE_LIBRARY_PATH'], 'libeail.so')
> +    if os.path.isfile(_libeail_path):
> +        os.environ['ACCESSIBILITY_EAIL_LIBRARY_PATH'] = _libeail_path
> +

(In reply to comment #7)
> One question. You made some changes to jhbuildrc. Could you tell me when
> those configurations are used ?.

I think developers don't know anything about ACCESSIBILITY_EAIL_LIBRARY_PATH 
environment variable, most of them are never set it to anything. 

In this common case jhbuild set ACCESSIBILITY_EAIL_LIBRARY_PATH to point to
DependenciesEFL/lib/libeail.so if this file exists to make your code happy.
If the optional module is built by jhbuild then run-webkit-tests, run-perf-tests,
run-launcher, ... pass through this env to WebKitTestRunner/MiniBrowser.
(efl.py change is needed to pass through the environment to WTR. Without
explicit request, environment variables aren't pass through to WTR.)

But if the user explicitly set ACCESSIBILITY_EAIL_LIBRARY_PATH env,
jhbuildrc doesn't change it, simply pass through to the WTR/MiniBrowser.