Bug 139037

Summary: [EFL] REGRESSION(r176514): It made performance tests fail
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gyuyoung.kim, k.czech, ossy, ryuan.choi
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 137742    
Attachments:
Description Flags
Patch
none
Patch none

Csaba Osztrogonác
Reported 2014-11-24 15:54:16 PST
details: https://bugs.webkit.org/show_bug.cgi?id=137742#c23 fix is coming
Attachments
Patch (3.97 KB, patch)
2014-11-24 16:01 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Patch (4.00 KB, patch)
2014-11-25 00:58 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2014-11-24 16:01:48 PST
Created attachment 242181 [details] Patch
Krzysztof Czech
Comment 2 2014-11-25 00:40:13 PST
Thanks Ossy for the fix, it's great.
Csaba Osztrogonác
Comment 3 2014-11-25 00:58:49 PST
Created attachment 242189 [details] Patch [EFL] prefix added to the changelog
Gyuyoung Kim
Comment 4 2014-11-25 01:20:55 PST
Comment on attachment 242189 [details] Patch LGTM.
WebKit Commit Bot
Comment 5 2014-11-25 01:59:22 PST
Comment on attachment 242189 [details] Patch Clearing flags on attachment: 242189 Committed r176538: <http://trac.webkit.org/changeset/176538>
WebKit Commit Bot
Comment 6 2014-11-25 01:59:27 PST
All reviewed patches have been landed. Closing bug.
Krzysztof Czech
Comment 7 2014-11-25 02:12:34 PST
One question. You made some changes to jhbuildrc. Could you tell me when those configurations are used ?.
Csaba Osztrogonác
Comment 8 2014-11-25 04:38:44 PST
Comment on attachment 242189 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=242189&action=review > Tools/efl/jhbuildrc:40 > +if not 'ACCESSIBILITY_EAIL_LIBRARY_PATH' in os.environ: > + _libeail_path = os.path.join(os.environ['CMAKE_LIBRARY_PATH'], 'libeail.so') > + if os.path.isfile(_libeail_path): > + os.environ['ACCESSIBILITY_EAIL_LIBRARY_PATH'] = _libeail_path > + (In reply to comment #7) > One question. You made some changes to jhbuildrc. Could you tell me when > those configurations are used ?. I think developers don't know anything about ACCESSIBILITY_EAIL_LIBRARY_PATH environment variable, most of them are never set it to anything. In this common case jhbuild set ACCESSIBILITY_EAIL_LIBRARY_PATH to point to DependenciesEFL/lib/libeail.so if this file exists to make your code happy. If the optional module is built by jhbuild then run-webkit-tests, run-perf-tests, run-launcher, ... pass through this env to WebKitTestRunner/MiniBrowser. (efl.py change is needed to pass through the environment to WTR. Without explicit request, environment variables aren't pass through to WTR.) But if the user explicitly set ACCESSIBILITY_EAIL_LIBRARY_PATH env, jhbuildrc doesn't change it, simply pass through to the WTR/MiniBrowser.
Note You need to log in before you can comment on or make changes to this bug.