Bug 139016

Summary: AX: [ATK] Unskip the skipped ATK tests in roles-exposed.html
Product: WebKit Reporter: Joanmarie Diggs <jdiggs>
Component: AccessibilityAssignee: Joanmarie Diggs <jdiggs>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mario, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Joanmarie Diggs
Reported 2014-11-23 13:08:58 PST
The roles-exposed.html test skips a lot of elements just for ATK on the basis that "it's not focusable" or "not to be exposed" or similar reasons. This is problematic: Things that are deliberately not to be exposed as separate accessible objects also require testing. If such objects (e.g. i, b, cite, mark) suddenly start showing up (being "exposed"), that might indicate a regression. We cannot catch such regressions if we do not test for them. Besides, it's being tested for the Mac and the expected results in a number of instances are an empty role. Why not do the same?
Attachments
Patch (29.90 KB, patch)
2014-11-23 13:39 PST, Joanmarie Diggs 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-11-23 13:09:11 PST
<rdar://problem/19069923>
Joanmarie Diggs
Comment 2 2014-11-23 13:21:57 PST
*** Bug 125491 has been marked as a duplicate of this bug. ***
Joanmarie Diggs
Comment 3 2014-11-23 13:30:12 PST
*** Bug 125493 has been marked as a duplicate of this bug. ***
Joanmarie Diggs
Comment 4 2014-11-23 13:39:28 PST
Created attachment 242136 [details] Patch
WebKit Commit Bot
Comment 5 2014-11-24 04:06:38 PST
Comment on attachment 242136 [details] Patch Clearing flags on attachment: 242136 Committed r176515: <http://trac.webkit.org/changeset/176515>
WebKit Commit Bot
Comment 6 2014-11-24 04:06:43 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.