Bug 139016

Summary:

AX: [ATK] Unskip the skipped ATK tests in roles-exposed.html

Product:

WebKit

Reporter:

Joanmarie Diggs <jdiggs>

Component:

Accessibility

Assignee:

Joanmarie Diggs <jdiggs>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, mario, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Description Joanmarie Diggs 2014-11-23 13:08:58 PST

The roles-exposed.html test skips a lot of elements just for ATK on the basis that "it's not focusable" or "not to be exposed" or similar reasons. This is problematic: Things that are deliberately not to be exposed as separate accessible objects also require testing. If such objects (e.g. i, b, cite, mark)  suddenly start showing up (being "exposed"), that might indicate a regression. We cannot catch such regressions if we do not test for them. Besides, it's being tested for the Mac and the expected results in a number of instances are an empty role. Why not do the same?

Comment 1 Radar WebKit Bug Importer 2014-11-23 13:09:11 PST

<rdar://problem/19069923>

Comment 2 Joanmarie Diggs 2014-11-23 13:21:57 PST

*** Bug 125491 has been marked as a duplicate of this bug. ***

Comment 3 Joanmarie Diggs 2014-11-23 13:30:12 PST

*** Bug 125493 has been marked as a duplicate of this bug. ***

Comment 4 Joanmarie Diggs 2014-11-23 13:39:28 PST

Created attachment 242136 [details]
Patch

Comment 5 WebKit Commit Bot 2014-11-24 04:06:38 PST

Comment on attachment 242136 [details]
Patch

Clearing flags on attachment: 242136

Committed r176515: <http://trac.webkit.org/changeset/176515>

Comment 6 WebKit Commit Bot 2014-11-24 04:06:43 PST

All reviewed patches have been landed.  Closing bug.