Bug 139016 - AX: [ATK] Unskip the skipped ATK tests in roles-exposed.html
Summary: AX: [ATK] Unskip the skipped ATK tests in roles-exposed.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joanmarie Diggs
URL:
Keywords: InRadar
: 125491 125493 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-11-23 13:08 PST by Joanmarie Diggs
Modified: 2014-11-24 04:06 PST (History)
3 users (show)

See Also:


Attachments
Patch (29.90 KB, patch)
2014-11-23 13:39 PST, Joanmarie Diggs
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joanmarie Diggs 2014-11-23 13:08:58 PST
The roles-exposed.html test skips a lot of elements just for ATK on the basis that "it's not focusable" or "not to be exposed" or similar reasons. This is problematic: Things that are deliberately not to be exposed as separate accessible objects also require testing. If such objects (e.g. i, b, cite, mark)  suddenly start showing up (being "exposed"), that might indicate a regression. We cannot catch such regressions if we do not test for them. Besides, it's being tested for the Mac and the expected results in a number of instances are an empty role. Why not do the same?
Comment 1 Radar WebKit Bug Importer 2014-11-23 13:09:11 PST
<rdar://problem/19069923>
Comment 2 Joanmarie Diggs 2014-11-23 13:21:57 PST
*** Bug 125491 has been marked as a duplicate of this bug. ***
Comment 3 Joanmarie Diggs 2014-11-23 13:30:12 PST
*** Bug 125493 has been marked as a duplicate of this bug. ***
Comment 4 Joanmarie Diggs 2014-11-23 13:39:28 PST
Created attachment 242136 [details]
Patch
Comment 5 WebKit Commit Bot 2014-11-24 04:06:38 PST
Comment on attachment 242136 [details]
Patch

Clearing flags on attachment: 242136

Committed r176515: <http://trac.webkit.org/changeset/176515>
Comment 6 WebKit Commit Bot 2014-11-24 04:06:43 PST
All reviewed patches have been landed.  Closing bug.