Bug 139007

Summary: Simple line layout: canUseFor() should iterate through RenderTexts to check if their content is eligible for simple line layout.
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, koivisto, kondapallykalyan, mmaxfield
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

alan
Reported 2014-11-22 15:24:04 PST
as opposed to just check the first child.
Attachments
Patch (3.64 KB, patch)
2014-11-22 15:43 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (10.32 KB, patch)
2014-11-23 17:12 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (10.19 KB, patch)
2014-11-24 13:33 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2014-11-22 15:43:56 PST
Created attachment 242124 [details] Patch
Antti Koivisto
Comment 2 2014-11-23 01:15:29 PST
Good catch. Needs some tests.
alan
Comment 3 2014-11-23 17:12:22 PST
Created attachment 242137 [details] Patch
Antti Koivisto
Comment 4 2014-11-24 00:26:37 PST
Comment on attachment 242137 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=242137&action=review > LayoutTests/ChangeLog:9 > + * fast/text/simple-line-layout-multiple-renderes-non-breaking-space-expected.html: Added. > + * fast/text/simple-line-layout-multiple-renderes-non-breaking-space.html: Added. These two files look identical?
alan
Comment 5 2014-11-24 13:33:09 PST
Created attachment 242171 [details] Patch
WebKit Commit Bot
Comment 6 2014-11-24 16:10:03 PST
Comment on attachment 242171 [details] Patch Clearing flags on attachment: 242171 Committed r176527: <http://trac.webkit.org/changeset/176527>
WebKit Commit Bot
Comment 7 2014-11-24 16:10:07 PST
All reviewed patches have been landed. Closing bug.
alan
Comment 8 2014-11-24 19:47:43 PST
Committed r176534: <http://trac.webkit.org/changeset/176534>
Note You need to log in before you can comment on or make changes to this bug.