Bug 139007

Summary: Simple line layout: canUseFor() should iterate through RenderTexts to check if their content is eligible for simple line layout.
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, koivisto, kondapallykalyan, mmaxfield
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description zalan 2014-11-22 15:24:04 PST 
as opposed to just check the first child.
Comment 1 zalan 2014-11-22 15:43:56 PST 
Created attachment 242124 [details]
Patch
Comment 2 Antti Koivisto 2014-11-23 01:15:29 PST 
Good catch. Needs some tests.
Comment 3 zalan 2014-11-23 17:12:22 PST 
Created attachment 242137 [details]
Patch
Comment 4 Antti Koivisto 2014-11-24 00:26:37 PST 
Comment on attachment 242137 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242137&action=review

> LayoutTests/ChangeLog:9
> +        * fast/text/simple-line-layout-multiple-renderes-non-breaking-space-expected.html: Added.
> +        * fast/text/simple-line-layout-multiple-renderes-non-breaking-space.html: Added.

These two files look identical?
Comment 5 zalan 2014-11-24 13:33:09 PST 
Created attachment 242171 [details]
Patch
Comment 6 WebKit Commit Bot 2014-11-24 16:10:03 PST 
Comment on attachment 242171 [details]
Patch

Clearing flags on attachment: 242171

Committed r176527: <http://trac.webkit.org/changeset/176527>
Comment 7 WebKit Commit Bot 2014-11-24 16:10:07 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 zalan 2014-11-24 19:47:43 PST 
Committed r176534: <http://trac.webkit.org/changeset/176534>