Bug 138989

Summary: The preview action menu item should not have a title
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, mitz, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch andersca: review+

Description Beth Dakin 2014-11-21 15:45:43 PST 
The preview action menu item should not have a title

rdar://problem/19061959
Comment 1 Beth Dakin 2014-11-21 15:48:56 PST 
Created attachment 242088 [details]
Patch
Comment 2 mitz 2014-11-21 15:52:56 PST 
Comment on attachment 242088 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242088&action=review

> Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:-843
> -        title = WEB_UI_STRING_KEY("Preview", "Preview (action menu item)", "action menu item");

Does this leave an unused key in the localizable strings file?
Comment 3 Beth Dakin 2014-11-21 15:54:47 PST 
(In reply to comment #2)
> Comment on attachment 242088 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=242088&action=review
> 
> > Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:-843
> > -        title = WEB_UI_STRING_KEY("Preview", "Preview (action menu item)", "action menu item");
> 
> Does this leave an unused key in the localizable strings file?

Not currently since we do still (intentionally) use the string in WK1.
Comment 4 Beth Dakin 2014-11-21 16:20:16 PST 
Thanks! http://trac.webkit.org/changeset/176485