Bug 138983

Summary: Properties in CSSPropertyNames.in should use the new StyleBuilder by default
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: CSSAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, kling, koivisto, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 138766    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Description Chris Dumez 2014-11-21 15:05:48 PST 
Properties in CSSPropertyNames.in should use the new StyleBuilder by default instead of having to specify [NewStyleBuilder] as option.
Comment 1 Chris Dumez 2014-11-21 15:34:55 PST 
Created attachment 242085 [details]
Patch
Comment 2 Andreas Kling 2014-11-21 16:53:19 PST 
Comment on attachment 242085 [details]
Patch

rs=me, though I think the option should be called DeprecatedStyleBuilder
Comment 3 Chris Dumez 2014-11-21 16:56:11 PST 
The reason I did not use "DeprecatedStyleBuilder" is because some of them are in DeprecatedStyleBuilder, some of them are in StyleResolver.

If I used "DeprecatedStyleBuilder", one might assume all those properties are implemented in DeprecatedStyleBuilder.cpp

In any case, this option is temporary.
Comment 4 Chris Dumez 2014-11-21 17:26:32 PST 
Comment on attachment 242085 [details]
Patch

Clearing flags on attachment: 242085

Committed r176491: <http://trac.webkit.org/changeset/176491>
Comment 5 Chris Dumez 2014-11-21 17:26:36 PST 
All reviewed patches have been landed.  Closing bug.