Bug 138983

Summary: Properties in CSSPropertyNames.in should use the new StyleBuilder by default
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: CSSAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, kling, koivisto, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 138766    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2014-11-21 15:05:48 PST
Properties in CSSPropertyNames.in should use the new StyleBuilder by default instead of having to specify [NewStyleBuilder] as option.
Attachments
Patch (52.68 KB, patch)
2014-11-21 15:34 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2014-11-21 15:34:55 PST
Created attachment 242085 [details] Patch
Andreas Kling
Comment 2 2014-11-21 16:53:19 PST
Comment on attachment 242085 [details] Patch rs=me, though I think the option should be called DeprecatedStyleBuilder
Chris Dumez
Comment 3 2014-11-21 16:56:11 PST
The reason I did not use "DeprecatedStyleBuilder" is because some of them are in DeprecatedStyleBuilder, some of them are in StyleResolver. If I used "DeprecatedStyleBuilder", one might assume all those properties are implemented in DeprecatedStyleBuilder.cpp In any case, this option is temporary.
Chris Dumez
Comment 4 2014-11-21 17:26:32 PST
Comment on attachment 242085 [details] Patch Clearing flags on attachment: 242085 Committed r176491: <http://trac.webkit.org/changeset/176491>
Chris Dumez
Comment 5 2014-11-21 17:26:36 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.