Bug 138962

Summary: [JSC] Disable verifyHeap
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren, mark.lam, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 138851    
Attachments:
Description Flags
Patch none

Description Csaba Osztrogonác 2014-11-21 05:36:35 PST 
[JSC] Disable verifyHeap
Comment 1 Csaba Osztrogonác 2014-11-21 05:36:46 PST 
Created attachment 242042 [details]
Patch

Disable verifyHeap, because it was enabled by mistake in r176424.
Comment 2 Csaba Osztrogonác 2014-11-21 05:39:23 PST 
In Bug138851 and in the changelog of http://trac.webkit.org/r176424
we can see clear that "The verification infrastructure code is always
built in but disabled by default."

So it seems it was enabled accidentally and should be disabled.

I noticed it, because this change made 30 JSC tests timeout our ARM bots:
- http://build.webkit.sed.hu/builders/EFL%20ARMv7%20Linux%20Release%20%28Build%29/builds/6996
- http://build.webkit.sed.hu/builders/EFL%20ARMv7%20Traditional%20Linux%20Release%20%28Build%29/builds/7745
Comment 3 Mark Lam 2014-11-21 06:48:08 PST 
Comment on attachment 242042 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2014-11-21 07:25:59 PST 
Comment on attachment 242042 [details]
Patch

Clearing flags on attachment: 242042

Committed r176446: <http://trac.webkit.org/changeset/176446>
Comment 5 WebKit Commit Bot 2014-11-21 07:26:03 PST 
All reviewed patches have been landed.  Closing bug.