Bug 138954

Summary: Move TextIndicator{Window} to WebCore
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, commit-queue, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch andersca: review+

Description Tim Horton 2014-11-21 02:38:32 PST
Move TextIndicator{Window} to WebCore
Comment 1 Tim Horton 2014-11-21 02:39:44 PST
Created attachment 242031 [details]
Patch
Comment 2 WebKit Commit Bot 2014-11-21 02:41:19 PST
Attachment 242031 [details] did not pass style-queue:


ERROR: Source/WebCore/page/mac/TextIndicatorWindow.h:51:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/mac/TextIndicatorWindow.h:65:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/mac/TextIndicatorWindow.mm:269:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/mac/WKViewInternal.h:84:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 4 in 32 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Csaba Osztrogonác 2014-11-21 04:41:32 PST
Created attachment 242040 [details]
Patch

patch for EWS with EFL buildfix: __MAC_OS_X_VERSION_MIN_REQUIRED is undefined on non MAC, PLATFORM(MAC) check is always needed.
Comment 4 WebKit Commit Bot 2014-11-21 04:43:13 PST
Attachment 242040 [details] did not pass style-queue:


ERROR: Source/WebCore/page/mac/TextIndicatorWindow.h:51:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/mac/TextIndicatorWindow.h:65:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/mac/TextIndicatorWindow.mm:269:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/mac/WKViewInternal.h:84:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 4 in 32 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Csaba Osztrogonác 2014-11-21 04:59:09 PST
Created attachment 242041 [details]
Patch

patch for EWS with EFL and GTK buildfixes: setTextIndicator in PageClient.h shouldn't be Mac only, fix parameter list in PageClientImpl cpp files too. (no changelog update included)
Comment 6 Csaba Osztrogonác 2014-11-21 05:00:38 PST
Comment on attachment 242031 [details]
Patch

add back r? and remove the obsolete flag, since it was unintentional
(webkit-patch did it automatically without asking)
Comment 7 WebKit Commit Bot 2014-11-21 05:02:39 PST
Attachment 242041 [details] did not pass style-queue:


ERROR: Source/WebCore/page/mac/TextIndicatorWindow.h:51:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/mac/TextIndicatorWindow.h:65:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/mac/TextIndicatorWindow.mm:269:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/mac/WKViewInternal.h:84:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 4 in 34 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Csaba Osztrogonác 2014-11-21 05:33:01 PST
(In reply to comment #3)
> Created attachment 242040 [details]
> Patch
> 
> patch for EWS with EFL buildfix: __MAC_OS_X_VERSION_MIN_REQUIRED is
> undefined on non MAC, PLATFORM(MAC) check is always needed.

(In reply to comment #5)
> Created attachment 242041 [details]
> Patch
> 
> patch for EWS with EFL and GTK buildfixes: setTextIndicator in PageClient.h
> shouldn't be Mac only, fix parameter list in PageClientImpl cpp files too.
> (no changelog update included)

GTK and EFL build is happy now with the latest patch. If you agree with my 
fixes, feel free to upload it for review as is after updating the changelog.
Comment 9 Tim Horton 2014-11-21 10:56:05 PST
Thanks for the changes, Ossy! I'll mark yours for r? and update the changelog upon landing (because laziness).
Comment 10 Tim Horton 2014-11-21 12:18:47 PST
http://trac.webkit.org/changeset/176462