Move TextIndicator{Window} to WebCore
Created attachment 242031 [details] Patch
Attachment 242031 [details] did not pass style-queue: ERROR: Source/WebCore/page/mac/TextIndicatorWindow.h:51: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/page/mac/TextIndicatorWindow.h:65: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/page/mac/TextIndicatorWindow.mm:269: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/mac/WKViewInternal.h:84: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 4 in 32 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 242040 [details] Patch patch for EWS with EFL buildfix: __MAC_OS_X_VERSION_MIN_REQUIRED is undefined on non MAC, PLATFORM(MAC) check is always needed.
Attachment 242040 [details] did not pass style-queue: ERROR: Source/WebCore/page/mac/TextIndicatorWindow.h:51: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/page/mac/TextIndicatorWindow.h:65: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/page/mac/TextIndicatorWindow.mm:269: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/mac/WKViewInternal.h:84: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 4 in 32 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 242041 [details] Patch patch for EWS with EFL and GTK buildfixes: setTextIndicator in PageClient.h shouldn't be Mac only, fix parameter list in PageClientImpl cpp files too. (no changelog update included)
Comment on attachment 242031 [details] Patch add back r? and remove the obsolete flag, since it was unintentional (webkit-patch did it automatically without asking)
Attachment 242041 [details] did not pass style-queue: ERROR: Source/WebCore/page/mac/TextIndicatorWindow.h:51: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/page/mac/TextIndicatorWindow.h:65: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/page/mac/TextIndicatorWindow.mm:269: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/mac/WKViewInternal.h:84: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 4 in 34 files If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #3) > Created attachment 242040 [details] > Patch > > patch for EWS with EFL buildfix: __MAC_OS_X_VERSION_MIN_REQUIRED is > undefined on non MAC, PLATFORM(MAC) check is always needed. (In reply to comment #5) > Created attachment 242041 [details] > Patch > > patch for EWS with EFL and GTK buildfixes: setTextIndicator in PageClient.h > shouldn't be Mac only, fix parameter list in PageClientImpl cpp files too. > (no changelog update included) GTK and EFL build is happy now with the latest patch. If you agree with my fixes, feel free to upload it for review as is after updating the changelog.
Thanks for the changes, Ossy! I'll mark yours for r? and update the changelog upon landing (because laziness).
http://trac.webkit.org/changeset/176462